Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Counterfactual] Implement the dashboard overview widget design #3214

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Feb 7, 2024

What it solves

Part of #3207

How this PR fixes it

  • Updates the design for the overview widget
  • Adds tracking for the Receive button and extends it by a label to differentiate between the same button in the sidebar

How to test it

  1. Open the dashboard
  2. Compare the new design (Figma)
  3. Make sure to also check Buy Crypto on a supported chain

Screenshots

Screenshot 2024-02-07 at 11 23 06 Screenshot 2024-02-07 at 11 23 18

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Feb 7, 2024

Copy link

github-actions bot commented Feb 7, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan
Copy link
Member Author

I didn't add the $ sign in front of the value as the currencies don't support it. We could add a custom mapping though from USD -> $, EUR -> € etc.

Copy link

github-actions bot commented Feb 7, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.02 MB (🟡 +12 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/balances/nfts 20.47 KB (-1 B) 1.04 MB
/home 40.3 KB (🟢 -520 B) 1.06 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Feb 7, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.61% 11402/14504
🔴 Branches 56.2% 2515/4475
🟡 Functions 63.18% 1810/2865
🟡 Lines 79.91% 10284/12869

Test suite run success

1389 tests passing in 188 suites.

Report generated by 🧪jest coverage report action from 857c394

@usame-algan usame-algan changed the title fix: Implement the dashboard overview widget design feat: Implement the dashboard overview widget design Feb 8, 2024
@mike10ca
Copy link
Contributor

mike10ca commented Feb 8, 2024

QA automation verified

Copy link

github-actions bot commented Feb 8, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan changed the title feat: Implement the dashboard overview widget design [Counterfactual] Implement the dashboard overview widget design Feb 8, 2024
@usame-algan usame-algan changed the base branch from dev to cf-dashboard February 9, 2024 14:08
@usame-algan usame-algan merged commit 911d7ea into cf-dashboard Feb 9, 2024
15 checks passed
@usame-algan usame-algan deleted the dashboard-overview branch February 9, 2024 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants