Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: detect duplicated signer in safe creation #3439

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

francovenica
Copy link
Contributor

@francovenica francovenica commented Mar 14, 2024

What it solves

Ticket #3427 fixed an issue of duplicated owner in safe creation in a specific scenario. This is an e2e-test that detects if that issue happens again

How this PR fixes it

Adds an address of the currently connected owner to the LS (like if it was added to the address book)
Uses the autocomplete feature in the safe creation owners' step to selecte the address added to the LS
Makes sure the "Duplicated signer" error shows up for that scenario

How to test it

Run the test "Verify duplicated signer error using the autocomplete feature" in the "create_test_simple" file. It should run fine
No other tests should be affected, so they all should run fine as well

Screenshots

image

Checklist

  • I've tested the branch on mobile πŸ“±
  • I've documented how it affects the analytics (if at all) πŸ“Š
  • I've written a unit/e2e test for it (if applicable) πŸ§‘β€πŸ’»

@francovenica francovenica self-assigned this Mar 14, 2024
Copy link

github-actions bot commented Mar 14, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: βœ… success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

πŸ“¦ Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

This PR introduced no changes to the JavaScript bundle! πŸ™Œ

Copy link

Coverage report

St.❔
Category Percentage Covered / Total
🟑 Statements 79.38% 11122/14011
πŸ”΄ Branches 58.4% 2610/4469
🟑 Functions 66.1% 1794/2714
🟒 Lines 80.64% 10018/12423

Test suite run success

1411 tests passing in 195 suites.

Report generated by πŸ§ͺjest coverage report action from ec72384

@francovenica francovenica merged commit daeb5b9 into dev Mar 15, 2024
14 checks passed
@francovenica francovenica deleted the e2e-duplicated-signers branch March 15, 2024 13:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants