Add support for API token expiration #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaavi
requested changes
Jul 21, 2022
There was a problem hiding this comment.
I think the expiry check is broken, possibly twice. ;)
Other related ideas:
- Should we validate the keys when setting them so we can return an error?
- Should we return an error if both read and write permissions are just
PermitAnyone? - Should we raise the default read permission to "PermitUser" to make more sense?
api/authentication.go
Outdated
| @@ -299,6 +300,14 @@ func checkAuth(w http.ResponseWriter, r *http.Request, authRequired bool) (token | |||
| return nil, false | |||
| } | |||
|
|
|||
| // Abort if the token is expired. | |||
| if token.ValidUntil != nil && token.ValidUntil.After(time.Now()) { | |||
There was a problem hiding this comment.
I think you meant time.Now().After(token.ValidUntil).
There was a problem hiding this comment.
This might better belong into checkAPIKey() - I'm not even sure it would be triggered here.
ppacher
force-pushed
the
feature/token-expiration
branch
from
e01bb96
to
4c6b834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.