Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging and PyPI distribution? #51

Open
matthewfeickert opened this issue Oct 4, 2021 · 5 comments
Open

Packaging and PyPI distribution? #51

matthewfeickert opened this issue Oct 4, 2021 · 5 comments

Comments

@matthewfeickert
Copy link

As you've made a library and are using it as such:

# snippet from toy_distributions.ipynb

# append parent directory to `sys.path`
# to load from modules in `../l2hmc-qcd/`
module_path = os.path.join('..')
if module_path not in sys.path:
    sys.path.append(module_path)

# Local imports
from utils.attr_dict import AttrDict
from utils.training_utils import train_dynamics
from dynamics.config import DynamicsConfig
from dynamics.base_dynamics import BaseDynamics
from dynamics.generic_dynamics import GenericDynamics
from network.config import LearningRateConfig
from config import (State, NetWeights, MonteCarloStates,
                    BASE_DIR, BIN_DIR, TF_FLOAT)

from utils.distributions import (plot_samples2D, contour_potential,
                                 two_moons_potential, sin_potential,
                                 sin_potential1, sin_potential2)

do you have any plans and/or interest in packaging it as a Python library so it can either be pip installed from GitHub or be distributed on PyPI?

@saforem2
Copy link
Owner

saforem2 commented Oct 4, 2021

Honestly it's something I've been meaning to do but just haven't gotten around to.

I'm not too familiar with the distribution side of packaging, so I'm not entirely sure what all it would require.

@matthewfeickert
Copy link
Author

Honestly it's something I've been meaning to do but just haven't gotten around to.

Cool. 👍

I'm not too familiar with the distribution side of packaging, so I'm not entirely sure what all it would require.

If you want to talk sometime I'd be very happy to help/give some advice on this. The short list of recommendations is:

I'm happy to discuss this here, over email, or on a call.

@saforem2
Copy link
Owner

saforem2 commented Oct 6, 2021

Sorry, I've been busy the past couple of days at this workshop but let me try getting into it over the weekend and see how it goes.

I'm happy to discuss this here, over email, or on a call.

Depending on how it goes, if I run into any issues or have any questions about anything I'll definitely make sure to take you up on this, thanks!

@matthewfeickert
Copy link
Author

Nothing to apologize about. :)

Depending on how it goes, if I run into any issues or have any questions about anything I'll definitely make sure to take you up on this, thanks!

Cool. I'm happy to look over any PRs as well. 👍

@saforem2 saforem2 mentioned this issue Jan 21, 2022
18 tasks
saforem2 added a commit that referenced this issue Feb 1, 2022
@saforem2
Copy link
Owner

Bit delayed, but it's available on PyPI at l2hmc!

I still plan to setup CI / automated tests + releases so I'll keep this open for the time being as a (mostly as a reminder for myself)

Also I just wanted to say thanks for raising this in the first place!

Ultimately this led me to rewrite / restructure the base of the code to address the (many) issues that I had been stringing along with hacks and duct tape to that point, and I think the code is better as a result (plus I learned a lot!)

saforem2 added a commit that referenced this issue Nov 7, 2022
Progress towards:
 - #51 (comment)


Former-commit-id: efb1f13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants