Go example for Command Line Arguments #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking with #2 |
sagar-jadhav
added
good first issue
|
@rishinair11 Please add details about changes added. It will set context for reviewers. |
ilmanzo
suggested changes
Oct 4, 2019
| ) | ||
|
|
||
| func startJob() { | ||
| //Defer is used to ensure that a function call is performed later |
There was a problem hiding this comment.
since the purpose is educational, I'd be more specfiic here; It's not only "later" but when the function returns to the caller
| // recover() is useful only when called inside deferred functions (here, recoverForm()). | ||
| // Executing a call to recover inside a deferred function stops the panicking sequence | ||
| // by restoring normal execution and retrieves the error value passed to the call of panic. | ||
| recoverObj := recover() |
There was a problem hiding this comment.
what can be the return value of recover() ? What do this object contains ?
| //occur during normal operation, or that aren't prepared | ||
| //to be handled gracefully | ||
|
|
||
| if name == nil { |
There was a problem hiding this comment.
checking for only name argument and not for the remaining two
rajkumarGosavi
requested changes
Oct 4, 2019
|
@rishinair11 Can you please have a look on review comments? |
|
Closing #16 due to inactivity. @rishinair11 Create separate PR once you are ready with changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.