Issue checkstyle#3910: CommitValidationTest: add character limit to line

sagar-shah94 · Mar 4, 2017 · f26c614 · f26c614
1 parent 8068599
commit f26c614
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/internal/CommitValidationTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/internal/CommitValidationTest.java
@@ -129,6 +129,11 @@ public void testCommitMessage() {
                 validateCommitMessage("minor: Test\n\n"));
         assertEquals("should accept commit message that ends properly", 0,
                 validateCommitMessage("minor: Test. Test"));
+        assertEquals("should accept commit message with less than or equal to 200 characters",
+                4, validateCommitMessage("minor: Test Test Test Test Test"
+                + "Test Test Test Test Test Test Test Test Test Test Test Test Test Test "
+                + "Test Test Test Test Test Test Test Test Test Test Test Test Test Test Test Test "
+                + "Test Test Test Test Test Test Test  Test Test Test Test Test Test"));
     }
 
     @Test
@@ -162,6 +167,10 @@ else if (INVALID_POSTFIX_PATTERN.matcher(message).matches()) {
             // improper postfix
             result = 3;
         }
+        else if (message.length() > 200) {
+            // commit message has more than 200 characters
+            result = 4;
+        }
         else {
             result = 0;
         }