Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Mestre's algorithm for constructing genus 2 hyperelliptic curves #6341

Closed
ncalexan mannequin opened this issue Jun 16, 2009 · 65 comments
Closed

implement Mestre's algorithm for constructing genus 2 hyperelliptic curves #6341

ncalexan mannequin opened this issue Jun 16, 2009 · 65 comments

Comments

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Jun 16, 2009

*** this ticket is still using the old workflow, just apply patches and ignore the "branch" field ***

An implementation of Mestre's algorithm for reconstructing genus 2 hyperelliptic curves from their invariants.

This is limited to fields of characteristic not 2, 3, 5 and to curves with automorphism group generated by the hyperelliptic involution. Curve equations are not reduced, hence are unusably large over QQ, but see below.

That's it. Various other tickets deal with extensions:

Apply:

CC: @ncalexan @mstreng @jpflori @sagetrac-lassina @fredstro

Component: number theory

Keywords: mestre algorithm genus 2 hyperelliptic curves sd35 sd51

Author: Florian Bouyer, Marco Streng

Branch: u/fstromberg/ticket/6341

Reviewer: Lassina Dembele, Fredrik Stromberg, Aly Deines

Merged: sage-5.13.beta0

Issue created by migration from https://trac.sagemath.org/ticket/6341

@ncalexan ncalexan mannequin assigned williamstein Jun 16, 2009
@ncalexan

This comment has been minimized.

@ncalexan
Copy link
Mannequin Author

ncalexan mannequin commented Jun 16, 2009

Attachment: trac_6341-mestre-extcode.patch.gz

@ncalexan
Copy link
Mannequin Author

ncalexan mannequin commented Jun 16, 2009

comment:2

Attachment: trac_6341-mestre.patch.gz

Here's a work in progress version. The extcode patch

  • updates Denis Simon's pari qfsolve program;
  • and incorporates Paul van Wamelen's pari genus 2 package.

The main devel patch integrates everything, or at least starts to.

@mstreng
Copy link

mstreng commented Jun 18, 2009

Attachment: trac_6341-mestre-without-conic.patch.gz

@mstreng
Copy link

mstreng commented Jun 18, 2009

comment:4

Attachment: trac_6341-mestre-extcode-without-qfsolve.patch.gz

The files "-without..." are the same as ncalexan's files, but with the Conic class removed and put in a separate patch at ticket 727. They still need the Conic class, but it may be better to view this as a separate enhancement.

@mstreng
Copy link

mstreng commented Jun 6, 2011

comment:5

This will be revived as part of a student project in August 2011.

@mstreng
Copy link

mstreng commented Dec 17, 2011

Changed keywords from mestre algorithm genus 2 hyperelliptic curves to mestre algorithm genus 2 hyperelliptic curves sd35

@mstreng
Copy link

mstreng commented Dec 17, 2011

Author: Florian Bouyer

@mstreng
Copy link

mstreng commented Dec 17, 2011

comment:6

Code was written by Florian Bouyer in September 2011, it works very nicely. Now it is a coding sprint at Sage Days 35 to put this in.

@sagetrac-florian
Copy link
Mannequin

sagetrac-florian mannequin commented Dec 19, 2011

Attachment: trac_6341_mestre_algorithm.patch.gz

An implementation of Mestre Algorithm

@mstreng
Copy link

mstreng commented Dec 19, 2011

comment:8

apply trac_6341_mestre_algorithm.patch

(this helps patchbot)

@mstreng

This comment has been minimized.

@mstreng
Copy link

mstreng commented Dec 20, 2011

comment:9

See also #12199, which will later fill in some special cases.

@sagetrac-florian
Copy link
Mannequin

sagetrac-florian mannequin commented Dec 20, 2011

comment:10

See also #12200, which will later fill in some special case

@sagetrac-florian
Copy link
Mannequin

sagetrac-florian mannequin commented Dec 20, 2011

minor changes to first patch

@sagetrac-florian
Copy link
Mannequin

sagetrac-florian mannequin commented Dec 20, 2011

comment:11

Attachment: trac_6341_mestre_algoritm_2.patch.gz

I corrected some typos and wasted white spaces pointed out by Marco

@sagetrac-florian

This comment has been minimized.

@sagetrac-florian

This comment has been minimized.

@mstreng

This comment has been minimized.

@mstreng
Copy link

mstreng commented Dec 22, 2011

comment:13

I'm reviewing and writing a reviewer's patch. Looks very good, but some small changes are needed that are easier to do than to explain.

@mstreng
Copy link

mstreng commented Dec 22, 2011

Reviewer: Marco Streng

@mstreng
Copy link

mstreng commented Jul 24, 2013

@mstreng
Copy link

mstreng commented Jul 24, 2013

Changed work issues from correct ticket number in error message, not 5534, but 14755 to complete references (title and journal with volume)

@mstreng

This comment has been minimized.

@mstreng
Copy link

mstreng commented Jul 25, 2013

comment:30

Attachment: 6341-more-corrections.3.patch.gz

(testing now)

@mstreng
Copy link

mstreng commented Jul 25, 2013

Changed work issues from complete references (title and journal with volume) to none

@mstreng
Copy link

mstreng commented Jul 25, 2013

Changed reviewer from Lassina Dembele to Lassina Dembele, Fredrik Stromberg

@mstreng
Copy link

mstreng commented Jul 25, 2013

comment:31

for patchbot:
apply 6341-mestre-only.patch and trac_6341-mestre-only_cleanup.patch and 6341-mestre-corrections.3.patch

@mstreng

This comment has been minimized.

@mstreng
Copy link

mstreng commented Jul 25, 2013

comment:33

apply 6341-mestre-only.patch and trac_6341-mestre-only_cleanup.patch and 6341-more-corrections.3.patch

@mstreng
Copy link

mstreng commented Aug 27, 2013

comment:34

I combined the patches into one, for easier review. Apply only 6341.patch

@mstreng

This comment has been minimized.

@mstreng
Copy link

mstreng commented Aug 28, 2013

ascii version of what was uploaded earlier this week

@fchapoton
Copy link
Contributor

comment:35

Attachment: 6341.patch.gz

apply only 6341.patch

@adeines
Copy link
Mannequin

adeines mannequin commented Sep 24, 2013

comment:36

This is working for me. I've verified several more non-CM examples in Magma.

@adeines
Copy link
Mannequin

adeines mannequin commented Sep 24, 2013

Changed reviewer from Lassina Dembele, Fredrik Stromberg to Lassina Dembele, Fredrik Stromberg, Aly Deines

@jdemeyer jdemeyer added this to the sage-5.13 milestone Sep 26, 2013
@jdemeyer
Copy link

jdemeyer commented Oct 2, 2013

Merged: sage-5.13.beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants