Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the sage-shell-view-mode #70

Closed
wants to merge 1 commit into from
Closed

Fix the sage-shell-view-mode #70

wants to merge 1 commit into from

Conversation

aikrahguzar
Copy link

@aikrahguzar aikrahguzar commented Feb 16, 2023 •
edited
Loading

I think this should fix #61

I haven't tested this. @EmmanuelCharpentier can you try if you have time?

It would be better to change supported_output to add OutputHtml to the supported_output of the parent class. And even better to raise the issue in sage-repository so that OutputHtml is not required to use OutputLatex.

@apresta
Copy link
Contributor

apresta commented Apr 7, 2023

I tried applying these changes and still ran into issues. First I had to add a missing import:

from sage.repl.rich_output.output_basic import OutputPlainText

Now I get this error: https://pastebin.com/pNL7yxNt

Looks like there are some problems with the generated LaTex code.

@aikrahguzar
Copy link
Author

I tried applying these changes and still ran into issues. First I had to add a missing import:

from sage.repl.rich_output.output_basic import OutputPlainText

Now I get this error: https://pastebin.com/pNL7yxNt

Looks like there are some problems with the generated LaTex code.

@apresta seems like there were changes in the LaTeX code generated by sage that broke the assumptions made by the sage-shell-view-mode. Maybe it is something simple which you can figure out by looking at the tex file mentioned in the error log you attached and then modify the latex generation in sage-shell-view-mode accordingly.

I will close this pr since it doesn't work but if you fix the problem, please open another one.

@aikrahguzar aikrahguzar closed this Apr 9, 2023
This was referenced Apr 9, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sage-shell-view-mode no longer working
2 participants
@aikrahguzar @apresta