Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of Gp in number_field.py #10002

Closed
jdemeyer opened this issue Sep 24, 2010 · 6 comments
Closed

Eliminate use of Gp in number_field.py #10002

jdemeyer opened this issue Sep 24, 2010 · 6 comments

Comments

@jdemeyer
Copy link

The file sage/rings/number_field/number_field.py uses the GP interpreter for some computations. It is probably more efficient to use the PARI library instead.

Dependencies: #9898, #9753, #4836, #10012

Component: number fields

Keywords: pari gp number field

Author: Jeroen Demeyer

Reviewer: John Cremona

Merged: sage-4.6.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/10002

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Attachment: 10002_remove_gp.patch.gz

@JohnCremona
Copy link
Member

Reviewer: John Cremona

@JohnCremona
Copy link
Member

Author: Jeroen Demeyer

@JohnCremona
Copy link
Member

comment:3

Applies fine to 4.6.1.alpha0.

It's a great idea to remove use of gp interpreter wherever possible. And since one of my to-do items is to handle S-unit groups (and S-class groups) as well as we do unit and class groups, and this will help, I am all in favour -- thanks!

I tested all sage/rings/number_fields and sage/schemes/elliptic_curves (since 2-descent code uses S-units), and all pass.

@jdemeyer
Copy link
Author

Merged: sage-4.6.1.alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants