New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed bug and new methods in Poset #10065
Comments
comment:2
The procedure is_isomorphic has two problems :
Maybe this can be corrected by having a method is_isomorphic for Lattices which is inherited from Posets. |
comment:3
One more thing to be corrected : The doc of !panyushev_orbits! is badly formatted. It does not display correctly in the notebook. |
comment:4
Replying to @fchapoton:
I only updated the doctest - the size/cardinality is in generic_graph.py. I am in the process to make changes to the is_isomorphic method in there anyway. I will make this little change in that other patch.
This was just a minor mistake in the is_isomorphic method for Posets. I updated it.
Done... |
comment:5
I uploaded a changed version of the patch containing a faster way to compute the Panyushev complement. Beside this, I didn't do any changes. |
comment:6
This last change makes some tests fail. See the shortlog by the buildbot. |
comment:7
Sorry Fred, I often forget to rebuild before making the test... if I didn't do more mistakes, it should work now.
trac_6641-poset_antichains_backtracker.patch (and uploaded them to the combinat queue) for ticket #6641. Could you probably fold them and add them to your ticket? Thanks! |
comment:8
These issues are addressed in #10998. |
Changed keywords from poset to poset, days30 |
comment:10
If this is a sage-duplicate, then I believe this ticket can be closed. |
Changed author from Christian Stump to none |
Reviewer: Franco Saliola |
Poset.dual contained a bug:
The patch contains the solution for this bug as well as new methods
is_lattice
is_isomorphic
is_selfdual
panyushev_complement
panyushev_orbits
CC: @saliola @fchapoton
Component: combinatorics
Keywords: poset, days30
Reviewer: Franco Saliola
Issue created by migration from https://trac.sagemath.org/ticket/10065
The text was updated successfully, but these errors were encountered: