Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "export FC=foo" to "FC=foo ; export FC" and similar in scipy_sandbox #10106

Closed
sagetrac-drkirkby mannequin opened this issue Oct 9, 2010 · 7 comments
Closed

Comments

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Oct 9, 2010

#10092 added 4 lines of code:

export FC="${SAGE_LOCAL}/bin/sage_fortran"
export F77="${SAGE_LOCAL}/bin/sage_fortran"
export F90="${SAGE_LOCAL}/bin/sage_fortran"
export F95="${SAGE_LOCAL}/bin/sage_fortran"

but using export and the variable name at the same time is not portable. For improved portability, which will work with any shell,

FC="${SAGE_LOCAL}/bin/sage_fortran"
export FC
F77="${SAGE_LOCAL}/bin/sage_fortran"
export F77
F90="${SAGE_LOCAL}/bin/sage_fortran"
export F90
F95="${SAGE_LOCAL}/bin/sage_fortran"
export F95

should work.

CC: @qed777 @kiwifb

Component: build

Author: David Kirkby

Reviewer: Mitesh Patel

Merged: sage-4.6.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/10106

@sagetrac-drkirkby sagetrac-drkirkby mannequin added this to the sage-4.6 milestone Oct 9, 2010
@sagetrac-drkirkby sagetrac-drkirkby mannequin added t: bug and removed p: major / 3 labels Oct 9, 2010
@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Oct 9, 2010

Improved portability, so will work with virtually any shell

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Oct 9, 2010

Author: David Kirkby

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Oct 9, 2010

comment:3

Attachment: 10106-imporve-portability-of-exports.patch.gz

The revised package may be found here. I've checked it on my OpenSolaris machine, but also on fulvia where it failed before:

Writing /home/drkirkby/fulvia/32/sage-4.5.2/local/lib/python2.6/site-packages/delaunay-0.0.0-py2.6.egg-info

real    0m39.298s
user    0m23.574s
sys     0m3.721s
Successfully installed scipy_sandbox-20071020.p7
Now cleaning up tmp files.
rm: Cannot remove any directory in the path of the current working directory
/home/drkirkby/fulvia/32/sage-4.5.2/spkg/build/scipy_sandbox-20071020.p7
Making Sage/Python scripts relocatable...
Making script relocatable
Finished installing scipy_sandbox-20071020.p7.spkg
32 drkirkby@fulvia:[~/fulvia/32/sage-4.5.2] $ uname -a
SunOS fulvia 5.10 Generic_127128-11 i86pc i386 i86pc

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Oct 9, 2010

comment:4

Oops, I forgot to post the link

http://boxen.math.washington.edu/home/kirkby/patches/scipy_sandbox-20071020.p7.spkg

@qed777
Copy link
Mannequin

qed777 mannequin commented Oct 9, 2010

Merged: sage-4.6.alpha3

@qed777
Copy link
Mannequin

qed777 mannequin commented Oct 9, 2010

comment:5

Thanks, David!

@qed777
Copy link
Mannequin

qed777 mannequin commented Oct 9, 2010

Reviewer: Mitesh Patel

@qed777 qed777 mannequin added s: positive review and removed s: needs review labels Oct 9, 2010
@qed777 qed777 mannequin closed this as completed Oct 9, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants