New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
random_prime is badly documented. #10111
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
See the patch at #10112. |
This comment has been minimized.
This comment has been minimized.
comment:3
Since there appears to be some disagreement about the code changes on #10112, if those can't be resolved soon, I suggest we just change the documentation on this ticket. The 3 changes needed are:
|
This comment has been minimized.
This comment has been minimized.
sagetrac-fwclarke
mannequin
added
s: positive review
and removed
s: needs review
labels
Feb 15, 2012
Reviewer: Francis Clarke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
random_prime()
function in Sage can take one, two or three arguments. But all the examples shown in the documentation orrandom_prime
use only one argument. The more complex cases are not documented and not tested.See also http://groups.google.com/group/sage-devel/browse_thread/thread/6e8d6f28c915830d?hl=en
These are the examples given.
Although some with good Python knowledge may argue the behavior with 2 or 3 arguments is documented properly, I personally think it could be clearer.
For example, I'm told:
would normally be written as
It would be good with someone with decent Python knowledge to write some examples of using this function with 2 or 3 arguments.
See also #10112, where it is shown that the function hangs for certain erroneous inputs.
It should also be noted that the error message "*n must be greater than lbound *" is incorrect, and should be changed to "n must be at least lbound"
Fixed by #10112, please close as duplicate.
CC: @sagetrac-fwclarke @burcin
Component: documentation
Reviewer: Francis Clarke
Issue created by migration from https://trac.sagemath.org/ticket/10111
The text was updated successfully, but these errors were encountered: