sage-location: "update" library files the first time this is run

[jhpalmieri]

If you build Sage but do not run it, then the script sage-location does not get run, so the file $SAGE_ROOT/local/lib/sage-current-location.txt does not get written. So if you move the Sage install directory before running it, the paths in the files SAGE_ROOT/local/lib/*.la are not correct. The attached patch updates the paths in those files if the file sage-current-location.txt does not exist.

(I'm marking this "minor" since it's not likely to happen at all frequently. When it does happen, it can screw things up pretty badly, though.)

CC: @nexttime

Component: build

Author: John Palmieri

Reviewer: Leif Leonhardy

Merged: sage-4.6.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/10162

[jhpalmieri]

scripts repo

[jhpalmieri]

comment:1

Attachment: trac_10162-sage-location.patch.gz

[nexttime]

comment:2

Except that the file's name is sage-current-location.txt...

Good catch by the way, I assumed it was an even larger, perhaps OS-related problem.

[nexttime]

Reviewer: Leif Leonhardy

[nexttime]

comment:3

Personal note (or to whom it may concern): ;-)

• Open a follow-up to also improve sage-sage:

  • Check exit code of sage-location before running sage-upgrade, too.
  • Call sage-location also before running sage-spkg.
  • Trap SIGINT while running sage-location(?) (such that we end up in a defined state in case it gets interrupted; perhaps requires further modification of sage-location as well)

• Open a follow-up to make sage-location a bit verbose? (aids debugging)

(I'm happy with this ticket as is, therefore further changes like the above should IMHO be made on follow-up tickets.)

[jdemeyer]

Merged: sage-4.6.1.alpha0

[nexttime]

comment:6

See #10202 for a follow-up (regarding when sage-location is called [first], and especially patching / "initializing" pkg-config's .pc files).