Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in sage/rings/arith.py #10210

Closed
jdemeyer opened this issue Nov 4, 2010 · 11 comments
Closed

Typos in sage/rings/arith.py #10210

jdemeyer opened this issue Nov 4, 2010 · 11 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Nov 4, 2010

Component: documentation

Author: Jeroen Demeyer

Reviewer: André Apitzsch

Merged: sage-4.6.1.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/10210

@jdemeyer
Copy link
Author

jdemeyer commented Nov 4, 2010

Author: Jeroen Demeyer

@nexttime
Copy link
Mannequin

nexttime mannequin commented Nov 4, 2010

comment:2

A height bound may be specified...

@nexttime
Copy link
Mannequin

nexttime mannequin commented Nov 4, 2010

comment:3

sufficiently small polynomial

@nexttime
Copy link
Mannequin

nexttime mannequin commented Nov 4, 2010

comment:4

requires height_bound to be set

Shouldn't sqrt(2) be typeset in math mode?

(Though I generally hate that: For every "p" in p-adic an image is generated by TeX for the HTML documentation, which takes by far more than half of the docbuild time.)

@nexttime nexttime mannequin changed the title Typo in sage/rings/arith.py Typos in sage/rings/arith.py Nov 4, 2010
@jdemeyer
Copy link
Author

jdemeyer commented Nov 4, 2010

comment:6

Requested changes done

@a-andre
Copy link

a-andre commented Nov 5, 2010

comment:7

It should be default*:*** (with colon)

@jdemeyer
Copy link
Author

jdemeyer commented Nov 5, 2010

comment:8

Attachment: 10210_algdep_doc.patch.gz

Replying to @a-andre:

It should be default*:*** (with colon)

Done.

@a-andre
Copy link

a-andre commented Nov 5, 2010

Reviewer: André Apitzsch

@johanrosenkilde
Copy link
Contributor

comment:10

Replying to @nexttime:

requires height_bound to be set

Shouldn't sqrt(2) be typeset in math mode?

(Though I generally hate that: For every "p" in p-adic an image is generated by TeX for the HTML documentation, which takes by far more than half of the docbuild time.)

Surely Sphinx caches and reuses these bits and pieces of TeX-generated images. A small grep for some of the more often used images (like $A$) seemed to indicate that at least...

@nexttime
Copy link
Mannequin

nexttime mannequin commented Nov 5, 2010

comment:11

Replying to @johanrosenkilde:

Replying to @nexttime:

requires height_bound to be set

Shouldn't sqrt(2) be typeset in math mode?

(Though I generally hate that: For every "p" in p-adic an image is generated by TeX for the HTML documentation, which takes by far more than half of the docbuild time.)

Surely Sphinx caches and reuses these bits and pieces of TeX-generated images. A small grep for some of the more often used images (like $A$) seemed to indicate that at least...

Might be true. Nevertheless, then even generating a single image file for every used math character (or short math-typeset identifier) takes a big amount of time, and btw. looks pretty ugly for e.g. p-adic in the HTML documentation. (The latter is what disturbs me more, but such mark-up is widely used in Sage, even for numbers in a word like 2-descent. If we one day build the documentation in parallel, too, the former is less of an issue, though it also takes more disk space. The ratio build:doc:ptestlong is about 3:2:3 on my newer machines; on older machines ptestlong takes longer.)

@jdemeyer
Copy link
Author

Merged: sage-4.6.1.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants