New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module_list.py: quaternion_algebra_element.pyx wrongly uses -std=c99 option #10260
Comments
comment:1
Attachment: 10260_quaternion_algebra_element_cpp.patch.gz |
comment:2
Tell you what. I introduced exactly the same patch in sage-on-gentoo at the end of June. While you are at it can we fix this one as well:
That's the only other with that "QA" problem. I'll happily give it a positive review. |
comment:3
Could you explain what "D_XPG6" is and why it's needed? (I've seen this elsewhere, and yet to have anyone justify it.) |
comment:4
Replying to @robertwb:
After a quick googling it looks like something ugly. First hit says: But that one is a little bit more verbose about what that flag is supposed to do: It seem to be regarded as a bad idea by a number of people. |
comment:5
I am giving the present patch a positive review. It is fairly simple and as actually been in use in sage-on-gentoo for a while. We can do the other one later in another ticket. |
comment:6
Replying to @kiwifb:
This one is harder, because there are two files, one C99 and one C++. So we cannot simply remove |
Reviewer: François Bissey |
Merged: sage-4.6.1.alpha2 |
It's C++ code...
Component: build
Author: Jeroen Demeyer
Reviewer: François Bissey
Merged: sage-4.6.1.alpha2
Issue created by migration from https://trac.sagemath.org/ticket/10260
The text was updated successfully, but these errors were encountered: