Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padics, precision, list() and printing #10292

Closed
roed314 opened this issue Nov 19, 2010 · 7 comments
Closed

padics, precision, list() and printing #10292

roed314 opened this issue Nov 19, 2010 · 7 comments

Comments

@roed314
Copy link
Contributor

roed314 commented Nov 19, 2010

sage: E = EllipticCurve('37a')
sage: R = E.padic_regulator(7)
sage: len(R.list())
37
sage: s = str(R)
sage: len(R.list())
19

Similarly:

sage: E = EllipticCurve('37a')
sage: R = E.padic_regulator(7)
sage: len(R.list())
37
sage: R.precision_absolute()
20
sage: len(R.list())
37
sage: R.precision_relative()
19
sage: len(R.list())
19

This is likely due to _normalize not getting called when necessary at object creation.

Apply:

  1. attachment: 10292.patch
  2. attachment: 10292_review.patch
    to the sage repository.

Component: padics

Author: David Roe

Reviewer: Johan Bosman

Merged: sage-4.8.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/10292

@roed314 roed314 added this to the sage-4.8 milestone Nov 19, 2010
@roed314 roed314 self-assigned this Nov 19, 2010
@roed314
Copy link
Contributor Author

roed314 commented Nov 9, 2011

Attachment: 10292.patch.gz

@sagetrac-johanbosman
Copy link
Mannequin

sagetrac-johanbosman mannequin commented Dec 1, 2011

Author: David Roe

@sagetrac-johanbosman
Copy link
Mannequin

sagetrac-johanbosman mannequin commented Dec 1, 2011

Reviewer: Johan Bosman

@sagetrac-johanbosman

This comment has been minimized.

@sagetrac-johanbosman
Copy link
Mannequin

sagetrac-johanbosman mannequin commented Dec 1, 2011

comment:2

Attachment: 10292_review.patch.gz

I've uploaded a patch that fixes the docstring formatting. If you agree with this, this can be given a positive_review.

@roed314
Copy link
Contributor Author

roed314 commented Dec 1, 2011

comment:3

Looks good to me. I should look over the Sphinx documentation to see when .. is advisable. The lack of :: was just an oversight.

@jdemeyer
Copy link

jdemeyer commented Dec 5, 2011

Merged: sage-4.8.alpha4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants