New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some remaining issues with sphinx-1.0.4.p3.spkg #10350
Comments
comment:1
New spkg: http://sage.math.washington.edu/home/jdemeyer/spkg/sphinx-1.0.4.p4.spkg |
Patch from p3 to p4, for review |
comment:2
Attachment: sphinx-1.0.4.p4.patch.gz From sage-release:
|
comment:4
P.S.: We should catch such automatically by |
comment:5
We have the correct dependencies in $(INST)/$(SPHINX): $(BASE) $(INST)/$(JINJA2) $(INST)/$(PATCH)
$(INSTALL) "$(SAGE_SPKG) $(SPHINX) 2>&1" "tee -a $(SAGE_LOGS)/$(SPHINX).log" but our Jinja2 is too old: ~/Sage/sage-4.6.1.alpha2$ ls spkg/standard/jinja2-*
spkg/standard/jinja2-2.1.1.p0.spkg |
Work Issues: Provide an upgraded Jinja2 (>=2.2) spkg |
This comment has been minimized.
This comment has been minimized.
comment:8
CC'ing the Jinja2 spkg maintainers. |
comment:9
I think an upgraded Jinja2 spkg is on the way, just a little patience... |
comment:10
I've opened #10423 for a new Jinja2 spkg (2.5.5), coming up soon. |
Changed work issues from Provide an upgraded Jinja2 (>=2.2) spkg to none |
comment:12
Replying to @nexttime:
Done, thanks for the suggestion. |
comment:13
Tested on the following machines together with sphinx-1.0.4.p4.spkg and jinja2-2.5.5.p0.spkg. I put these updated packages in the source tarball of Sage 4.6.1.alpha2 and built Sage from source. After a successful build from source, I grep'd through
Grep'ing through the various
The documentation build process didn't hang at the above error, but continued on until the end.
The documentation build process didn't hang at the above error, but continued on until the end.
I'm OK with all changes in the updated spkg. But note the following minor issues:
the part "Jinja >= 2," should be changed to "Jinja >= 2.5.5," as per ticket #10423.
If the above changes are made, this ticket should get a positive review. |
Reviewer: Minh Van Nguyen |
comment:14
Replying to @sagetrac-mvngu:
I'd say >=2.2 as required by this Sphinx version; 2.5.5 is currently the latest. Btw, any ideas about Jinja2's true dependencies (cf. this comment)? Upstream only explicitly mentions Python and setuptools (alternatively, preferably "distribute"). |
comment:16
New spkg: http://sage.math.washington.edu/home/jdemeyer/spkg/sphinx-1.0.4.p5.spkg |
p4 to p5 patch for reference |
comment:17
Attachment: sphinx-1.0.4.p5.patch.gz The updated spkg is good to go. Thanks! |
This comment has been minimized.
This comment has been minimized.
Merged: sage-4.6.1.alpha3 |
comment:19
Stylewise, I would have used a This could easily be modified without touching the patch at all. I would also use |
Changed keywords from sphinx spkg to sphinx spkg utf8x LaTeX error titlesec |
comment:20
Replying to @nexttime:
I suppose there is no harm in doing this, but I don't see much gain either.
Why? I dislike conditional stuff without a good reason. |
comment:21
Replying to @jdemeyer:
It's more flexible and eases maintaining, in any case.
I don't like generally disabling things or introducing artificial limits just because there are problems on some platforms or installations. In the case of |
comment:22
Replying to @nexttime:
If that happens, we need to completely drop support for |
This ticket is a follow-up to #10118 (merged in sage-4.6.1.alpha2)
Here are some trivial problems in the file
SPKG.txt
of version ".p3" of the Sphinx package:we should have "Pygments >= 1.3.1" due to ticket #10290, and "Jinja2 >= 2**.2**". But this is no biggy; it's a trivial typo that can either (i) be fixed in a new ticket, or (ii) fixed in the current ticket.
the fragment
should be changed to
Tested on the following platforms:
{sage.math, bsd.math, hawk}: Both HTML and PDF versions of documentation built OK. For the PDF version, building the reference manual produced some warnings about "unusable reference target", which are to do with relative links to other documents in the Sage standard documentation.
{cleo, iras}.skynet: Sage 4.6.1.alpha2 fails to build on this machine, hence the documentation doesn't get built at all.
{cicero, eno, lena, sextus, taurus, t2}: The HTML version of the documentation mostly built OK, but with warnings about a missing LaTeX installation. Consequently, the PDF version of the documentation can't be built.
flavius.skynet -- The PDF version of the documentation built fine, but with some warnings about unusable relative links. The HTML version built with numerous warnings due to missing the dvipng command.
{gcc11, gcc16}.fsffrance.org: The HTML version of all documents in the standard documentation mostly built OK, but with warnings about the missing command "dvipng". This machine has a LaTeX installation, but it is missing the file titlesec.sty, hence building the PDF version of any document in the standard documentation would hang at the error message:
to use only utf8 instead of utf8x. The same change needs to be made to the file
doc/common/conf.py
. See my reviewer patch attachment: trac-10118_use-utf8.patch. With this patch, we get pass the issue of the missing utf8x.def, but we now run into the following error:Apply:
CC: @kcrisman @TimDumol @jhpalmieri @mwhansen
Component: packages: standard
Keywords: sphinx spkg utf8x LaTeX error titlesec
Author: Jeroen Demeyer
Reviewer: Minh Van Nguyen
Merged: sage-4.6.1.alpha3
Issue created by migration from https://trac.sagemath.org/ticket/10350
The text was updated successfully, but these errors were encountered: