Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10303 gives problems with sage -ba-force #10436

Closed
jdemeyer opened this issue Dec 6, 2010 · 6 comments
Closed

#10303 gives problems with sage -ba-force #10436

jdemeyer opened this issue Dec 6, 2010 · 6 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Dec 6, 2010

On a clean installation of Sage including #10303, I get

$ ./sage -ba-force
*** TOUCHING ALL CYTHON (.pyx) FILES ***
KeyError: 'SAGE64':
  File "/mnt/usb1/scratch/jdemeyer/merger/sage-4.6.1.rc0/devel/sage-main/c_lib/SConstruct", line 108:
    if os.environ['SAGE64']=="yes":
  File "/mnt/usb1/scratch/jdemeyer/merger/sage-4.6.1.rc0/local/lib/python/UserDict.py", line 22:
    raise KeyError(key)

----------------------------------------------------------
sage: Building and installing modified Sage library files.

Apart from this error message, sage -ba-force seems to work.

CC: @nexttime

Component: build

Keywords: SAGE64

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/10436

@jdemeyer

This comment has been minimized.

@jhpalmieri
Copy link
Member

comment:2

I think running sage-check-64 earlier in sage-build would fix it (if we keep #10303). Something like this patch:

diff -r 3d7bb3a7774e sage-build
--- a/sage-build
+++ b/sage-build
@@ -82,6 +82,13 @@ if [ ! -d "$SAGE_ROOT/devel/sage" ]; the
     exit 1
 fi
 
+# Check whether this seems to a 64-bit build:
+source "$SAGE_LOCAL"/bin/sage-check-64
+
+if [ $? -ne 0 ]; then
+    exit 1
+fi
+
 if [ $DO_BUILD_ALL = 1 ]; then
    CUR=`pwd`
    cd "$SAGE_ROOT/devel/sage/sage"
@@ -98,11 +105,4 @@ if [ $DO_BUILD_ALL = 1 ]; then
    cd "$CUR"
 fi
 
-# Check whether this seems to a 64-bit build:
-source "$SAGE_LOCAL"/bin/sage-check-64
-
-if [ $? -ne 0 ]; then
-    exit 1
-fi
-
 build "sage"

But it's the end of the quarter here, I have final exams to prepare, etc., so I don't have any more time to work on this now.

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Dec 6, 2010

comment:3

I do not see this problem on a build where SAGE64 was not set.

drkirkby@hawk:~/sage-4.6.1.alpha3$ ./sage -ba-force
*** TOUCHING ALL CYTHON (.pyx) FILES ***
scons: `install' is up to date.

----------------------------------------------------------
sage: Building and installing modified Sage library files.


Installing c_lib

This was a 32-bit build on OpenSolaris 06/2009.

What system was the problem noticed? Was SAGE64 set?

@jdemeyer
Copy link
Author

jdemeyer commented Dec 7, 2010

comment:4

Replying to @sagetrac-drkirkby:

What system was the problem noticed? Was SAGE64 set?

This was on sage.math.washington.edu, a Ubuntu Linux x86_64 system. I did not set SAGE64.

@jdemeyer jdemeyer modified the milestones: sage-4.6.1, sage-4.6.2 Dec 16, 2010
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@jdemeyer
Copy link
Author

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link
Author

comment:9

Ticket is irrelevant since #10303 was never merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants