Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move integer factorization functions to a separate file #10623

Closed
a-andre opened this issue Jan 13, 2011 · 8 comments
Closed

Move integer factorization functions to a separate file #10623

a-andre opened this issue Jan 13, 2011 · 8 comments
Labels
c: factorization p: critical / 2 t: enhancement
Milestone
sage-4.7.1

Comments

@a-andre
Copy link

a-andre commented Jan 13, 2011

See #1145 comment:14.

Depends on #5945.

CC: @sagetrac-spancratz

Component: factorization

Author: André Apitzsch

Reviewer: David Kirkby, Mariah Lenox

Merged: sage-4.7.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/10623
@a-andre a-andre added this to the sage-4.7 milestone Jan 13, 2011
@a-andre a-andre changed the title Move integer factorization functions to a separat file Move integer factorization functions to a separate file Jan 13, 2011
@a-andre
Copy link
Author

a-andre commented Jan 18, 2011

Attachment: trac_10623.patch.gz

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Apr 27, 2011

Reviewer: David Kirkby

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Apr 27, 2011

comment:2

I verified the examples using Mathematica, but can't comment on the rest of the ticket.

I think it's useful to indicate how the results are known to be correct. In this case I agree they are.

Dave

@robertwb
Copy link
Contributor

Dependencies: #5945

@sagetrac-mariah
Copy link
Mannequin

sagetrac-mariah mannequin commented May 18, 2011

Changed reviewer from David Kirkby to David Kirkby, Mariah Lenox

@sagetrac-mariah
Copy link
Mannequin

sagetrac-mariah mannequin commented May 18, 2011

comment:4

I applied the patch to sage-4.7.rc2, did 'sage -b', and then ran
'make testlong'. All tests passed. Positive review.

@jdemeyer
Copy link

Changed dependencies from #5945 to none

@jdemeyer jdemeyer modified the milestones: sage-4.7, sage-4.7.1 May 19, 2011
@jdemeyer
Copy link

Merged: sage-4.7.1.alpha2

@zimmermann6 zimmermann6 mentioned this issue Dec 29, 2022
Open
@a-andre a-andre mentioned this issue Jan 17, 2011
Closed
@lftabera lftabera mentioned this issue Jul 11, 2012
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: factorization p: critical / 2 t: enhancement
Projects
None yet
Milestone
sage-4.7.1
Development

No branches or pull requests
3 participants
@robertwb @jdemeyer @a-andre