Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patchbot to the developers guide #10702

Closed
mstreng opened this issue Jan 27, 2011 · 10 comments
Closed

Add patchbot to the developers guide #10702

mstreng opened this issue Jan 27, 2011 · 10 comments

Comments

@mstreng
Copy link

mstreng commented Jan 27, 2011

Add a link to the patchbot wiki in the developers guide (see this thread).

CC: @jdemeyer

Component: documentation

Keywords: patchbot, buildbot, bot, trac, developers guide

Author: Marco Streng

Reviewer: André Apitzsch

Merged: sage-4.6.2.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/10702

@mstreng
Copy link
Author

mstreng commented Jan 27, 2011

Author: Marco Streng

@mstreng
Copy link
Author

mstreng commented Jan 27, 2011

Changed keywords from none to patchbot, buildbot, bot, trac, developers guide

@mstreng mstreng added this to the sage-4.6.2 milestone Jan 27, 2011
@a-andre
Copy link

a-andre commented Jan 28, 2011

Reviewer: André Apitzsch

@a-andre
Copy link

a-andre commented Jan 28, 2011

comment:2

It looks good to me.

@jdemeyer
Copy link

comment:3

Marco: please fix the commit message of your patch (use hg qrefresh -e for that).

@mstreng
Copy link
Author

mstreng commented Jan 31, 2011

Attachment: trac_10702-patchbot-doc.patch.gz

@mstreng
Copy link
Author

mstreng commented Jan 31, 2011

comment:4

What do you mean by "fix"? Is it ok now? That was a lot of work for just removing "[mq]: " (of which I don't know where it came from or what it means).

@jdemeyer
Copy link

comment:5

Replying to @mstreng:

What do you mean by "fix"? Is it ok now? That was a lot of work for just removing "[mq]: " (of which I don't know where it came from or what it means).

Yes, it looks okay now. The [mq] stands for "Mercurial queue". By default the commit message comes from the argument to hg qnew. But in Sage, we like to have "proper" informative commit messages (also, including the ticket number on the first line).

Why was it a lot of work, what did you do?

@mstreng
Copy link
Author

mstreng commented Jan 31, 2011

comment:6

Replying to @jdemeyer:

Why was it a lot of work, what did you do?

log in to a machine that has Sage, copy patch location, hg qimport, hg qapply, hg qrefresh -e, remove "[mq]: " from the commit message, hg export, copy patch to office pc, log in to trac, upload patch, tick needs_review, click Submit

All that to remove four characters from a commit message.

Why couldn't I just edit the patch to remove those 4 characters? Would it have screwed up some kind of checksum?

@jdemeyer
Copy link

jdemeyer commented Feb 7, 2011

Merged: sage-4.6.2.alpha4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants