Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local solubility of conics over number fields #10742

Closed
mstreng opened this issue Feb 4, 2011 · 22 comments
Closed

Local solubility of conics over number fields #10742

mstreng opened this issue Feb 4, 2011 · 22 comments

Comments

@mstreng
Copy link

mstreng commented Feb 4, 2011

Use Hilbert symbols to test local solubility of conics over number fields.

Apply attachment: 10742.2.patch

Depends on #10621
Depends on #9334
Depends on #11455

CC: @sagetrac-florian

Component: number fields

Keywords: conic hilbert symbol number field

Author: Marco Streng

Reviewer: Florian Bouyer

Merged: sage-5.3.rc0

Issue created by migration from https://trac.sagemath.org/ticket/10742

@mstreng
Copy link
Author

mstreng commented Feb 6, 2011

This is the difference between the first two patches of #10621. It contains the local solubility code, but also reverses some fixes of #10621. Select good parts from this patch and make it into a new patch.

@mstreng
Copy link
Author

mstreng commented Sep 30, 2011

Dependencies: #10621, #9334

@mstreng
Copy link
Author

mstreng commented Sep 30, 2011

Changed work issues from wait for the pari bug of #9334 to be resolved to write a patch

@mstreng

This comment has been minimized.

@mstreng
Copy link
Author

mstreng commented Sep 30, 2011

comment:1

Attachment: trac_10742_do_not_apply.patch.gz

@mstreng
Copy link
Author

mstreng commented Feb 3, 2012

Changed dependencies from #10621, #9334 to #10621, #9334, #11455

@mstreng
Copy link
Author

mstreng commented Feb 3, 2012

Attachment: 10742.patch.gz

@mstreng
Copy link
Author

mstreng commented Feb 3, 2012

Changed work issues from write a patch to none

@mstreng
Copy link
Author

mstreng commented Feb 3, 2012

comment:3

apply 10742.patch

@mstreng

This comment has been minimized.

@mstreng mstreng changed the title Make Conics over number fields use hilbert symbols over number fields. Local solubility of conics over number fields Feb 3, 2012
@mstreng
Copy link
Author

mstreng commented Feb 3, 2012

Work Issues: wait for the problem with #11455 to be fixed, then rebase if necessary

@mstreng
Copy link
Author

mstreng commented Feb 3, 2012

comment:5

With this patch on 5.0.prealpha1, all tests pass. Applies cleanly on top of the new version of #11455, so no rebase was necessary.

@mstreng
Copy link
Author

mstreng commented Feb 3, 2012

Changed work issues from wait for the problem with #11455 to be fixed, then rebase if necessary to none

@mstreng
Copy link
Author

mstreng commented Aug 14, 2012

comment:7

does not apply due to new changes in #11455

@mstreng

This comment has been minimized.

@mstreng
Copy link
Author

mstreng commented Aug 14, 2012

rebase

@mstreng
Copy link
Author

mstreng commented Aug 14, 2012

comment:8

Attachment: 10742.2.patch.gz

testing now; apply 10742.2.patch

@mstreng

This comment has been minimized.

@mstreng
Copy link
Author

mstreng commented Aug 14, 2012

comment:9

all tests pass, please review!

@sagetrac-florian
Copy link
Mannequin

sagetrac-florian mannequin commented Aug 17, 2012

comment:10

It passed all test (including long) and the documents turned out fine. I've played around with it and it works.

@sagetrac-florian
Copy link
Mannequin

sagetrac-florian mannequin commented Aug 17, 2012

Reviewer: Florian Bouyer

@jdemeyer
Copy link

Merged: sage-5.3.rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants