Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

by default build HTML doc without PDF links #10811

Closed
sagetrac-mvngu mannequin opened this issue Feb 21, 2011 · 14 comments
Closed

by default build HTML doc without PDF links #10811

sagetrac-mvngu mannequin opened this issue Feb 21, 2011 · 14 comments

Comments

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 21, 2011

The Makefile currently (Sage 4.6.2.rc0) builds the HTML document with links to the PDF version. But if only the HTML document is built, then the generated links would be broken links. This can be fixed by getting Makefile to by default build the HTML documentation without linking to the PDF version. Also, the Makefile should contain instructions on how to build both the HTML and PDF versions and have the HTML version link to the PDF version.

See this sage-devel thread for background information.

Apply:

  1. attachment: trac-10811_Makefile.patch
  2. attachment: trac-10811_docbuild.patch

Component: documentation

Author: Minh Van Nguyen

Reviewer: Mariah Lenox

Merged: sage-4.7.1.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/10811

@sagetrac-mvngu sagetrac-mvngu mannequin added this to the sage-4.7 milestone Feb 21, 2011
@sagetrac-mvngu sagetrac-mvngu mannequin self-assigned this Feb 21, 2011
@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Feb 21, 2011

Attachment: Makefile.gz

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Feb 21, 2011

Author: Minh Van Nguyen

@sagetrac-mvngu

This comment has been minimized.

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Feb 21, 2011

comment:1

Attachment: Makefile.diff.gz

Only apply Makefile; i.e. replace the current Makefile with the updated Makefile on this ticket. The file Makefile.diff serves only to show the proposed changes.

@kcrisman
Copy link
Member

comment:2

Hmm, but who reads Makefiles for documentation? Maybe adding something elsewhere in the documentation to specifically mention this - and the (apparently?) change in default behavior - would make it more effective.

@sagetrac-mvngu

This comment has been minimized.

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Feb 27, 2011

comment:3

Attachment: trac-10811_docbuild.patch.gz

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Feb 27, 2011

comment:4

Replying to @kcrisman:

Maybe adding something elsewhere in the documentation to specifically mention this - and the (apparently?) change in default behavior - would make it more effective.

Done. See the additional patch.

@sagetrac-mariah
Copy link
Mannequin

sagetrac-mariah mannequin commented May 18, 2011

comment:5

sage-4.7.rc2 built with this ticket's Makefile correctly causes HTML documentation to be built without PDF links. Documentation patch looks good. Positive review.

@sagetrac-mariah
Copy link
Mannequin

sagetrac-mariah mannequin commented May 18, 2011

Reviewer: Mariah Lenox

@jdemeyer
Copy link

comment:6

Please add a proper hg changeset for the Makefile instead of a simple diff.

@sagetrac-mariah
Copy link
Mannequin

sagetrac-mariah mannequin commented May 19, 2011

Attachment: trac-10811_Makefile.patch.gz

@sagetrac-mariah

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Jun 8, 2011

Merged: sage-4.7.1.alpha3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants