New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
by default build HTML doc without PDF links #10811
Comments
Attachment: Makefile.gz |
Author: Minh Van Nguyen |
This comment has been minimized.
This comment has been minimized.
comment:1
Attachment: Makefile.diff.gz Only apply |
comment:2
Hmm, but who reads Makefiles for documentation? Maybe adding something elsewhere in the documentation to specifically mention this - and the (apparently?) change in default behavior - would make it more effective. |
This comment has been minimized.
This comment has been minimized.
comment:3
Attachment: trac-10811_docbuild.patch.gz |
comment:4
Replying to @kcrisman:
Done. See the additional patch. |
comment:5
sage-4.7.rc2 built with this ticket's Makefile correctly causes HTML documentation to be built without PDF links. Documentation patch looks good. Positive review. |
Reviewer: Mariah Lenox |
comment:6
Please add a proper hg changeset for the Makefile instead of a simple diff. |
Attachment: trac-10811_Makefile.patch.gz |
This comment has been minimized.
This comment has been minimized.
Merged: sage-4.7.1.alpha3 |
The
Makefile
currently (Sage 4.6.2.rc0) builds the HTML document with links to the PDF version. But if only the HTML document is built, then the generated links would be broken links. This can be fixed by gettingMakefile
to by default build the HTML documentation without linking to the PDF version. Also, theMakefile
should contain instructions on how to build both the HTML and PDF versions and have the HTML version link to the PDF version.See this sage-devel thread for background information.
Apply:
Component: documentation
Author: Minh Van Nguyen
Reviewer: Mariah Lenox
Merged: sage-4.7.1.alpha3
Issue created by migration from https://trac.sagemath.org/ticket/10811
The text was updated successfully, but these errors were encountered: