Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commutator subgroup for permutation groups #10921

Closed
rbeezer mannequin opened this issue Mar 12, 2011 · 7 comments
Closed

Commutator subgroup for permutation groups #10921

rbeezer mannequin opened this issue Mar 12, 2011 · 7 comments
Assignees
@wdjoyner
Labels
c: group theory p: minor / 4 t: enhancement
Milestone
sage-4.7

Comments

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Mar 12, 2011

Wraps GAP's CommutatorSubgroup and DerivedSubgroup.

CC: @dimpase

Component: group theory

Author: Rob Beezer

Reviewer: Dmitrii Pasechnik, David Joyner

Merged: sage-4.7.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/10921
@rbeezer rbeezer mannequin added this to the sage-4.7 milestone Mar 12, 2011
@rbeezer rbeezer mannequin added c: group theory labels Mar 12, 2011
@rbeezer rbeezer mannequin assigned wdjoyner Mar 12, 2011
@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Mar 12, 2011

Attachment: trac_10921-commutator-permutation-groups.patch.gz

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Mar 12, 2011

Author: Rob Beezer

@rbeezer rbeezer mannequin added the s: needs review label Mar 12, 2011
@wdjoyner
Copy link

comment:2

This applies fine to 4.6.2.a1. It passes sage -testall except for an unrelated failure in the R interface module. As far as I can see, the code and docstrings look very good.

I'm going to test it on another machine.

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Mar 13, 2011

comment:3

If this does not apply properly, try 4.7.alpha1, plus #10871, #10920, where I have checked that it does apply.

@dimpase
Copy link
Member

dimpase commented Mar 14, 2011

comment:4

Works! Positive review.

@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Mar 15, 2011

Reviewer: Dmitrii Pasechnik, David Joyner

@jdemeyer
Copy link

Merged: sage-4.7.alpha3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wdjoyner wdjoyner

Labels
c: group theory p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-4.7
Development

No branches or pull requests
3 participants
@wdjoyner @dimpase @jdemeyer