Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lie bracket operation in Rings() #10961

Closed
nthiery opened this issue Mar 18, 2011 · 10 comments
Closed

Add Lie bracket operation in Rings() #10961

nthiery opened this issue Mar 18, 2011 · 10 comments

Comments

@nthiery
Copy link
Contributor

nthiery commented Mar 18, 2011

From the documentation:

    sage: F = AlgebrasWithBasis(QQ).example(); F
    An example of an algebra with basis: the free algebra on the generators ('a', 'b', 'c') over Rational Field
    sage: a,b,c = F.algebra_generators()
    sage: F.bracket(a,b)
    B[word: ab] - B[word: ba]

Apply trac_10961-lie_bracket_in_rings-nt.patch

Component: algebra

Author: Nicolas M. Thiéry

Reviewer: Anne Schilling

Merged: sage-4.7.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/10961

@nthiery nthiery added this to the sage-4.7 milestone Mar 18, 2011
@anneschilling
Copy link

comment:1

The patch implements the Lie bracket and it would be good to merge it into sage soon. However, the tests in /categories/rings.py line 70 do not pass due to the misprint
{{
sage: a,b,c = FF.algebra_generators()
}}
should be
{{
sage: a,b,c = F.algebra_generators()
}}

@anneschilling
Copy link

Reviewer: Anne Schilling

@nthiery
Copy link
Contributor Author

nthiery commented Mar 26, 2011

comment:2

Replying to @anneschilling:

The patch implements the Lie bracket and it would be good to merge it into sage soon. However, the tests in /categories/rings.py line 70 do not pass due to the misprint
{{
sage: a,b,c = FF.algebra_generators()
}}
should be
{{
sage: a,b,c = F.algebra_generators()
}}

Shoot; I had noticed this, and got distracted. Thanks for the reminder! Fixed!

@nthiery nthiery changed the title Add Lie bracket operation in Rings Add Lie bracket operation in Rings() Mar 26, 2011
@nthiery
Copy link
Contributor Author

nthiery commented Mar 26, 2011

Attachment: wifi.gz

Please delete this file!

@nthiery
Copy link
Contributor Author

nthiery commented Mar 26, 2011

Attachment: trac_10961-lie_bracket_in_rings-nt.patch.gz

Final version

@nthiery

This comment has been minimized.

@anneschilling
Copy link

comment:4

Looks good!

@nthiery
Copy link
Contributor Author

nthiery commented Mar 26, 2011

comment:5

Thanks for the review!

@anneschilling

This comment has been minimized.

@jdemeyer jdemeyer modified the milestones: sage-4.7, sage-4.7.1 Apr 13, 2011
@jdemeyer
Copy link

Merged: sage-4.7.1.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants