New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in permutation_automorphism_group for linear codes #10994
Comments
comment:1
Thomas also points out that the code only checks minimal weight vectors:
This code is, frankly, terrible. I figured out after a bit of searching that this was introduced into sage at #4320 by David Joyner. Michael Abshoff gave the ticket a positive review based on a misunderstood conversation we had. I did not sufficiently examine the code to vouch for it, but I think he wanted to get it merged anyway. If one looks at the code before that ticket, one sees the true intention of the algorithm which was a bit butchered at #4320. Related to this is ticket #11032, which is specific to the binary case. I'll fix both of these to do the right thing, since I'm probably in the best position to do so. In fact, I think I'm going to suggest we remove automorphism_group_binary_code completely since we now have all cases. |
comment:2
See #11033, which will fix this problem. |
comment:3
After applying #10871 and #11033:
|
Changed author from Thomas Feulner to none |
Reviewer: Robert Miller |
The method
permutation_automorphism_group
gives different results for the two optionsmethod="gap"
andmethod="partition":
The application of ticket:10153 indicates that the problem is caused by
method="partition"
.CC: @rlmill
Component: coding theory
Reviewer: Robert Miller
Issue created by migration from https://trac.sagemath.org/ticket/10994
The text was updated successfully, but these errors were encountered: