Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute heights of Dyck words and compare them #11196

Closed
hivert opened this issue Apr 14, 2011 · 10 comments
Closed

Compute heights of Dyck words and compare them #11196

hivert opened this issue Apr 14, 2011 · 10 comments

Comments

@hivert
Copy link

hivert commented Apr 14, 2011

Currently one can only compute the maximal height of a Dyck word. The patch add computing the sequence of heights and also comparing two Dyck words.

Since I needed it, I also added two function to compute a Dyck word from its heights sequence and to compute a minimal Dyck word knowing a lower bound for the heights.

Apply :

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: Dyck words, height, sd31

Author: Florent Hivert

Reviewer: Mike Hansen

Merged: sage-4.7.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/11196

@hivert hivert added this to the sage-4.7.1 milestone Apr 14, 2011
@hivert hivert self-assigned this Apr 14, 2011
@mwhansen
Copy link
Contributor

comment:2

I posted a new patch which just fixes a small typo in the docstring. I think that HeightPoset should be renamed to height_poset since that's what one would expect.

@hivert
Copy link
Author

hivert commented Jun 13, 2011

comment:3

Thanks you for the review !

Replying to @mwhansen:

I posted a new patch which just fixes a small typo in the docstring. I think that HeightPoset should be renamed to height_poset since that's what one would expect.

Even if it is actually a class ?

@mwhansen
Copy link
Contributor

comment:4

Replying to @hivert:

Even if it is actually a class ?

I think so since it's more of a shortcut instead of defining a HeightPoset outside of the class and then having a height_poset method which returns an object of that type.

@hivert
Copy link
Author

hivert commented Jun 13, 2011

@hivert
Copy link
Author

hivert commented Jun 13, 2011

comment:5

Hi Mike,

I just uploaded a new patch which address your comment. It also add a two new function related to heights.

How did you manage to replace my patch ? I got an error saying that I don't have the right to remove yours. Maybe its because you are a trac admin.

@hivert

This comment has been minimized.

@mwhansen
Copy link
Contributor

comment:6

Looks good to me.

@mwhansen
Copy link
Contributor

Changed keywords from Dyck words, height to Dyck words, height, sd31

@mwhansen
Copy link
Contributor

Reviewer: Mike Hansen

@jdemeyer
Copy link

Merged: sage-4.7.2.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants