Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document "%edit" in the tutorial #11219

Closed
jhpalmieri opened this issue Apr 19, 2011 · 12 comments
Closed

document "%edit" in the tutorial #11219

jhpalmieri opened this issue Apr 19, 2011 · 12 comments

Comments

@jhpalmieri
Copy link
Member

The attached patch adds documentation for the %edit command in the Sage tutorial.


Apply attachment: trac_11219-ipython-edit.v2.patch.

CC: @kcrisman

Component: documentation

Author: John Palmieri

Reviewer: John Cremona

Merged: sage-4.7.rc0

Issue created by migration from https://trac.sagemath.org/ticket/11219

@jhpalmieri
Copy link
Member Author

comment:1

Attachment: trac_11219-ipython-edit.patch.gz

@jhpalmieri
Copy link
Member Author

comment:2

This is related to #7586, by the way.

@JohnCremona
Copy link
Member

comment:3

The patch applies and builds fine. I learned a lot from reading the tutorial after testing that!

One thing does not work as advertised, I think: using logstart. I could not load unless I gave the logfile a suffix such as .sage or .py, note that the stored commands are preparsed before being stored. But when the file is loaded in another session I do not see this

Loading log file <setup> one line at a time...
    Finished replaying log file <setup>

but rather this


sage: load "setup.py"
Activating auto-logging. Current session state plus future input saved.
Filename       : setup.py
Mode           : backup
Output logging : False
Raw input log  : False
Timestamping   : False
State          : active

which does load the stuff but also overwrites the file setup.py!!!

So I'm giving this a positive review but want the other thing fixed before we forget all about it.

@jhpalmieri
Copy link
Member Author

Reviewer: John Cremona

@jhpalmieri
Copy link
Member Author

comment:4

In response to kcrisman's comment on sage-devel, I added a little bit about commands run in the background not being preparsed. Could you do another review on that? I'm posting a new patch ("...v2.patch") and another patch showing the difference, for easy reference.

@jhpalmieri
Copy link
Member Author

Attachment: trac_11219-ipython-edit.v2.patch.gz

apply only this patch

@jhpalmieri
Copy link
Member Author

difference between versions 1 and 2, for reference only

@jhpalmieri

This comment has been minimized.

@jhpalmieri
Copy link
Member Author

comment:5

Attachment: trac_11219-ipython-edit.delta.patch.gz

@jdemeyer
Copy link

comment:7

Looks safe enough for sage-4.7-rc0.

@jdemeyer jdemeyer modified the milestones: sage-4.7.1, sage-4.7 Apr 20, 2011
@jdemeyer
Copy link

Merged: sage-4.7.rc0

@kcrisman
Copy link
Member

kcrisman commented Feb 3, 2013

comment:9

This never made it into the translations of the tutorial - German, French, or Russian. I don't know if they existed at the time in any case, but I've opened #14051 for this. I don't know if the newer translations not yet in I reference their have this stuff or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants