Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in documentation for non_surjective for Galois representations attached to elliptic curves #11276

Closed
sagetrac-dpathakjee mannequin opened this issue Apr 30, 2011 · 3 comments

Comments

@sagetrac-dpathakjee
Copy link
Mannequin

sagetrac-dpathakjee mannequin commented Apr 30, 2011

non_surjective() docstring incorrectly states that it's inconclusive and often wrong for p=2. The function it calls, is_surjective, is correct for p=2.

The docstring states that "[the] list of primes p such that the mod-p representation might not be surjective... usually contains 2, because of shortcomings of the algorithm..." However, non_surjective calls is_surjective, which should always be correct for p=2,3 because it computes the Galois group of the 2-division polynomial. (More precisely, its helper, _is_surjective, does this.) I suspect this caveat may have been written before the special cases for p=2,3 in _is_surjective had been written.

All that really needs to be done is to remove the phrase "(this list usually contains 2, because of shortcomings of the algorithm)" from the docstring.

See also #11271, #11270

CC: @williamstein

Component: elliptic curves

Keywords: galois representation, non_surjective

Reviewer: Chris Wuthrich

Issue created by migration from https://trac.sagemath.org/ticket/11276

@fchapoton

This comment has been minimized.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@chriswuthrich
Copy link
Contributor

comment:3

This is a duplicate (well, striclty speaking a sub-ticket) of #11271. This should be closed.

@chriswuthrich chriswuthrich removed this from the sage-6.1 milestone Dec 30, 2013
@pjbruin
Copy link
Contributor

pjbruin commented Dec 30, 2013

Reviewer: Chris Wuthrich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants