Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad formatting in hasse_diagram #11365

Closed
kcrisman opened this issue May 21, 2011 · 6 comments
Closed

Bad formatting in hasse_diagram #11365

kcrisman opened this issue May 21, 2011 · 6 comments
Assignees
@sagetrac-mvngu
Labels
c: documentation p: trivial / 5 t: bug
Milestone
sage-4.7.1

Comments

@kcrisman
Copy link
Member

See this page, at the definition of complements and further. Must be missing some colons or something.

CC: @sagetrac-sage-combinat

Component: documentation

Author: Minh Van Nguyen

Reviewer: Mariah Lenox

Merged: sage-4.7.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/11365
@kcrisman kcrisman added this to the sage-4.7.1 milestone May 21, 2011
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 21, 2011

Author: Minh Van Nguyen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 21, 2011

comment:1

Attachment: trac-11365_hasse-diagram-typos.patch.gz

@sagetrac-mariah
Copy link
Mannequin

sagetrac-mariah mannequin commented May 24, 2011

Reviewer: Mariah Lenox

@sagetrac-mariah
Copy link
Mannequin

sagetrac-mariah mannequin commented May 24, 2011

comment:2

Applied patch, did 'sage -b', then './sage -docbuild reference html',
and verified that the patch correctly formated the tests and examples of the functions 'complements()', 'cover_relations()', and 'cover_relations_iterator()'. Positive review.

@nthiery
Copy link
Contributor

nthiery commented May 25, 2011

comment:3

Hi Minh,

Thanks for the improvements!

Luckily, it seems like this will commute smoothly with #10998. So I leave the positive review. But please synchronise with us next time!

Cheers,

@jdemeyer
Copy link

Merged: sage-4.7.1.alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-mvngu sagetrac-mvngu

Labels
c: documentation p: trivial / 5 t: bug
Projects
None yet
Milestone
sage-4.7.1
Development

No branches or pull requests
3 participants
@nthiery @kcrisman @jdemeyer