Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not modify permissions on vcs-tracked scripts in sage-make_devel_packages #11492

Closed
kini opened this issue Jun 15, 2011 · 6 comments
Closed

Do not modify permissions on vcs-tracked scripts in sage-make_devel_packages #11492

kini opened this issue Jun 15, 2011 · 6 comments
Labels
c: scripts r: wontfix t: bug

Comments

@kini
Copy link
Contributor

kini commented Jun 15, 2011

As above. Mercurial tracks file permissions, so there is no reason to modify them after unpacking them, as is done in lines 139-141 of $SAGE_LOCAL/sage-make_devel_packages. Right?

Continued from #11449.

Apply:

  1. attachment: 11492_root_perm.patch to SAGE_ROOT
  2. attachment: 11492_scripts_perm.patch to SAGE_LOCAL/bin

CC: @jdemeyer @gvol

Component: scripts

Issue created by migration from https://trac.sagemath.org/ticket/11492
@kini kini added this to the sage-5.11 milestone Jun 15, 2011
@jdemeyer
Copy link

Attachment: 11492_root_perm.patch.gz

@jdemeyer
Copy link

Attachment: 11492_scripts_perm.patch.gz

@jdemeyer
Copy link

Author: Jeroen Demeyer

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@mezzarobba
Copy link
Member

comment:5

make_devel_package disappeared with the switch to git (commit 48ff645).

@mezzarobba
Copy link
Member

Changed author from Jeroen Demeyer to none

@mezzarobba mezzarobba removed this from the sage-6.2 milestone Feb 5, 2014
@vbraun vbraun closed this as completed Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: scripts r: wontfix t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kini @vbraun @jdemeyer @mezzarobba @a-andre