Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trac #1092 small memleaks exposed by ntl_ZZ_pE (from 2.8.12.alpha0) #11495

Closed
jpflori opened this issue Jun 16, 2011 · 6 comments
Closed

Trac #1092 small memleaks exposed by ntl_ZZ_pE (from 2.8.12.alpha0) #11495

jpflori opened this issue Jun 16, 2011 · 6 comments
Assignees
@rlmill
Labels
p: critical / 2 t: bug
Milestone
sage-4.7.2

Comments

@jpflori
Copy link

jpflori commented Jun 16, 2011

The patch for ticket #1092 has been reverted by commit 8503, so the (not so) small memleaks are back.

CC: @sagetrac-mabshoff @wjp @jpflori @sagetrac-bober

Component: memleak

Author: Willem Jan Palenstijn

Reviewer: Jonathan Bober

Merged: sage-4.7.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/11495
@jpflori jpflori added this to the sage-4.7.1 milestone Jun 16, 2011
@jpflori
Copy link
Author

jpflori commented Jun 16, 2011

original patch for #1092

@jpflori
Copy link
Author

jpflori commented Jun 24, 2011

comment:1

Attachment: memleak_ZZ_pE_to_ZZ_pX.patch.gz

@sagetrac-bober
Copy link
Mannequin

sagetrac-bober mannequin commented Jul 25, 2011

Reviewer: Jonathan Bober

@sagetrac-bober
Copy link
Mannequin

sagetrac-bober mannequin commented Jul 25, 2011

comment:2

This looks good to me. It is a simple -1 line change that removes the creation of an unnecessary that is never deleted.

@jdemeyer jdemeyer modified the milestones: sage-4.7.1, sage-4.7.2 Jul 27, 2011
@jdemeyer
Copy link

Changed author from wjp to Willem Jan Palenstijn

@jdemeyer
Copy link

Merged: sage-4.7.2.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlmill rlmill

Labels
p: critical / 2 t: bug
Projects
None yet
Milestone
sage-4.7.2
Development

No branches or pull requests
2 participants
@jpflori @jdemeyer