Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sage library fails to build on Cygwin #11499

Closed
kcrisman opened this issue Jun 16, 2011 · 12 comments
Closed

Sage library fails to build on Cygwin #11499

kcrisman opened this issue Jun 16, 2011 · 12 comments

Comments

@kcrisman
Copy link
Member

The file sage/rings/factorint.pyx needs to add libraries=['gmp'] as a dependency now.

CC: @mwhansen @dimpase @williamstein

Component: porting: Cygwin

Author: Karl-Dieter Crisman

Reviewer: Reg Burgess

Merged: sage-4.7.2.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/11499

@kcrisman

This comment has been minimized.

@kcrisman

This comment has been minimized.

@kcrisman
Copy link
Member Author

Author: Karl-Dieter Crisman

@kcrisman
Copy link
Member Author

comment:3

This apparently still isn't quite the right fix.

@kcrisman
Copy link
Member Author

Attachment: trac_11499.patch.gz

@kcrisman

This comment has been minimized.

@kcrisman
Copy link
Member Author

comment:5

This needs review. Given the troubles building on Win7, checking that this doesn't break our 'normal' builds and one other person checking on XP should be sufficient to review.

@kcrisman
Copy link
Member Author

comment:7

I've now checked this a number of times on Cygwin in the course of building Sage. It would be really nice for someone to make sure this doesn't break anything on 'normal' systems, and hopefully to check it on at least one Windows box - if only so that I don't have to manually fix it whenever I get to the middle of building the Sage spkg!

@kcrisman
Copy link
Member Author

comment:8

User "RegB" was able to use this successfully for this - see this sage-windows thread.

So this should have positive review. Hopefully I can get a "real" name for this person.

@kcrisman
Copy link
Member Author

comment:9

Reg confirmed this attribution by real name was ok in a private email. Welcome to the Sage community, Reg!

@kcrisman
Copy link
Member Author

Reviewer: Reg Burgess

@jdemeyer
Copy link

Merged: sage-4.7.2.alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants