Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test_executable timeout in ppl.pyx #11534

Closed
jdemeyer opened this issue Jun 22, 2011 · 7 comments
Closed

Increase test_executable timeout in ppl.pyx #11534

jdemeyer opened this issue Jun 22, 2011 · 7 comments

Comments

@jdemeyer
Copy link

In devel/sage/sage/libs/ppl.pyx, there are various tests of the form

(out, err, ret) = test_executable(['sage', '-c', sage_cmd])

It turns out that these commonly result in timeouts (much more often than the basic tests in sage/tests/cmdline.py). The proposal is to increase the timeouts in ppl.pyx.

Component: doctest coverage

Author: Jeroen Demeyer

Reviewer: Volker Braun

Merged: sage-4.7.1.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/11534

@jdemeyer
Copy link
Author

comment:1

Attachment: 11534_ppl_timeout.patch.gz

@vbraun
Copy link
Member

vbraun commented Jun 22, 2011

comment:2

Yes, good point. I keep forgetting that not everybody runs on a solid state drive. Those tests don't take any time at all on my system, but if you run on NFS then the startup can be painful.

Positive review!

@vbraun
Copy link
Member

vbraun commented Jun 22, 2011

Reviewer: Volker Braun

@jdemeyer
Copy link
Author

Merged: sage-4.7.1.alpha3

@jdemeyer
Copy link
Author

comment:4

Unfortunately, now I am regularly hitting the "whole file" timeout for ppl.pyx on various systems. A timeout of ppl.pyx is now one of the most common reasons for a build to fail on the buildbot. I think the test takes too long, although I cannot rule out a true bug. Volker, any ideas to fix this?

@vbraun
Copy link
Member

vbraun commented Aug 18, 2011

comment:5

Some doctests spawn a new sage process because they are testing debugging output that ppl writes to stdout. Presumably these take a long time on machines where Sage startup takes forever. How about we mark all doctests that spawn a new sage process as

  # optional - FAST_SAGE_STARTUP

or something like that? We do test the ppl functionality independently, so they aren't really necessary for doctest coverage. If you agree with this then I can make a patch.

@jdemeyer
Copy link
Author

comment:6

Actually I discovered the problem is not related to test_executable but it is instead #11849.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants