New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PermutationGroup coercion bug #1155
Comments
comment:2
This patch doesn't feel right to me; it seems like it's fixing the problem at the wrong level. (For instance, it sometimes breaks if you try to create a permutation group from a list of generators where some of the generators are Python lists and some are Gap permutation group elements. Maybe that's too strange a case to worry about?) I haven't tried it, but it looks like adding a special case to gap_format() for Gap permutation group elements would also fix the problem, perhaps in a better way? |
comment:3
Also, there are no doctests in the patch. |
comment:4
I've put a new patch up. |
Attachment: 1155.patch.gz |
comment:6
Code looks good; doctest passes. |
comment:7
Merged in Sage 2.10.1.rc1 |
The patch
http://sage.math.washington.edu/home/wdj/patches/permgp-2007-11-12.hg
fixes a bug reported by Carlo H. Part of his email is pasted below:
+++++++++++++++++++++++++++++++++++++++++++++++
Hi,
I'm doing some work with groups. Using gap.Image() I can get a
permutation like this:
But to make a permutation group out of this element I have to enclose
the x in two sets of brackets:
On the other hand, the following command fails (see below for code and output):
In my mind the second version is clearer - x is a permutation so [x]
is a list of permutations and I should be able to use that to get a
group.
Should SAGE do a coercion here, or am I doing something in a strange way?
Code and output:
CC: @sagetrac-sage-combinat
Component: combinatorics
Keywords: GAP, permutation group
Issue created by migration from https://trac.sagemath.org/ticket/1155
The text was updated successfully, but these errors were encountered: