Turn Fan(discard_warning) into an error

[vbraun]

There is no easy way to re-enable the warning after it has been shown once. A typical use case is that you have a mistake in your fan data and you want to fix it. The fact that the warning for duplicate cones is only shown once in the Sage session is very annoying.

Apply attachment: trac_11627_alternative.patch

CC: @novoselt

Component: geometry

Author: Andrey Novoseltsev

Reviewer: Volker Braun

Merged: sage-4.7.2.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/11627

[novoselt]

comment:1

OK, I'll change it ;-)

[vbraun]

comment:2

I do have a patch, I just haven't had the time to finish it.

[novoselt]

comment:3

Namewise, how about replacing disacard_warning, which will not make sense anymore, with discard_faces=False that can be set to True to allow it?

[vbraun]

Attachment: trac_11627_make_fan_raise_errors.patch.gz

Initial patch

[vbraun]

comment:4

Here is my take on it. I renamed it to check_duplicate_cones=<bool> to make clear that it is related to the check optional argument.

[vbraun]

Author: Volker Braun

[vbraun]

comment:5

Any thoughts on the patch?

[novoselt]

comment:6

Hi Volker, sorry for the delay - travel/jetlag/work ;-)

Discarding faces and repeated cones is quite natural when they come from some construction and I have already wished a few times that it would be possible to drop them without using check=True option which does much more work. In fact, that's the reason why there is a function discard_faces. So I propose this patch which adds a discard_faces=False keyword which works independently of check. I have also fixed the code and documentation pieces that were relying on the old behaviour, I don't get now any errors for tests in geometry or schemes directories.

[novoselt]

Attachment: trac_11627_alternative.patch.gz

[vbraun]

comment:7

Looks good!

[vbraun]

Changed author from Volker Braun to Andrey Novoseltsev

[vbraun]

Reviewer: Volker Braun

[nexttime]

Merged: sage-4.7.2.alpha3