moin files not world-readable

[jdemeyer]

Similar to #11660, the moin files are not world-readable.

New spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/moin-1.9.1.p2.spkg

Component: packages: standard

Author: Jeroen Demeyer

Reviewer: Leif Leonhardy

Merged: sage-4.7.1.rc2

Issue created by migration from https://trac.sagemath.org/ticket/11662

[jdemeyer]

Author: Jeroen Demeyer

[nexttime]

Reviewer: Leif Leonhardy

[nexttime]

comment:2

Did you make spkg-install executable?

While hg log shows spkg-install had been modified, hg diff doesn't.

I think we should really set the umask in spkg-install (or sage-spkg), since otherwise changing the permissions of the upstream files and those in patches/ doesn't help much in this case.

Otherwise positive review; the files that were previously only readable / executable by the user or group are now world-readable, and executable if appropriate (provided the umask doesn't prevent this).

spkg-install is sub-optimal btw.

[jdemeyer]

comment:3

Replying to @nexttime:

Did you make spkg-install executable?

Perhaps, I don't remember.

While hg log shows spkg-install had been modified

Where do you see this?

[jdemeyer]

Merged: sage-4.7.1.rc2

[nexttime]

comment:4

Replying to @jdemeyer:

Replying to @nexttime:

Did you make spkg-install executable?

Perhaps, I don't remember.

Well, I could have looked at the previous spkg. ;-)

While hg log shows spkg-install had been modified

Where do you see this?

hg log -v also shows which files have been touched in each changeset.