Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another example of simplicial complex : the K3 surface #11703

Closed
fchapoton opened this issue Aug 18, 2011 · 16 comments
Closed

another example of simplicial complex : the K3 surface #11703

fchapoton opened this issue Aug 18, 2011 · 16 comments

Comments

@fchapoton
Copy link
Contributor

I propose to add to the list of simplicial complexes the minimal triangulation of the K3 surface, which has 16 vertices and 288 facets.

sage: simplicial_complexes.K3_surface()
Simplicial complex with vertex set (1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16) and 288 facets

This is can either be defined by storing the data or by recovering it using a group action. What should I prefer ?

Reference : Combinatorial properties of the K3 surface:
Simplicial blowups and slicings by Jonathan Spreer & Wolfgang Kühnel


Apply

CC: @sagetrac-sage-combinat

Component: algebraic topology

Keywords: simplicial complex

Author: Frédéric Chapoton

Reviewer: John Palmieri

Merged: sage-4.7.2.alpha3

Issue created by migration from https://trac.sagemath.org/ticket/11703

@jhpalmieri
Copy link
Member

comment:1

Adding the K3 surface would be great. Can you describe what's involved for the two approaches (storing the data or using the group action)? Then I could make a better suggestion about which to use here.

@vbraun
Copy link
Member

vbraun commented Aug 18, 2011

comment:2

That would be nice! If there is some reasonably easy way to construct the complex from a group action then it should be done that way so that others can learn from the source code. But just listing raw data would be fine with me, too.

@fchapoton
Copy link
Contributor Author

comment:3

Here is the code with the group (of size 240) and the orbit closure. The other option is just a long list.

def K3_surface():
    """
    Returns the minimal triangulation of the K3 surface. This is a simplicial complex with 16 vertices and 288 facets.

    EXAMPLES::
        sage: K3=simplicial_complexes.K3_surface() ; K3
        Simplicial complex with vertex set (1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16) and 288 facets
        sage: K3.f_vector()
        [1, 16, 120, 560, 720, 288]

    REFERENCES:
        - Combinatorial properties of the K3 surface: Simplicial blowups and slicings by Jonathan Spreer & Wolfgang Kühnel
        - M. Casella and W. K¨uhnel, A triangulated K3 surface with the minimum number of vertices, Topology 40 (2001), 753–772.
    """
    G = PermutationGroup([[(1,3,8,4,9,16,15,2,14,12,6,7,13,5,10)],[(1,11,16),(2,10,14),(3,12,13),(4,9,15),(5,7,8)]])
    gen1=(1,2,3,8,12)      
    gen2=(1,2,5,8,14)
    liste=[tuple([g(i) for i in gen1]) for g in G]+[tuple([g(i) for i in gen2]) for g in G]
    return SimplicialComplex(liste)

@jhpalmieri
Copy link
Member

comment:4

The group action approach looks good to me. Can you post a patch?

@kcrisman
Copy link
Member

comment:5

Can I "like" this?

Also, don't forget the sage developer guide for some nitpicky things about the docstring - this will save the reviewer (presumably jhpalmieri himself) some effort.

@fchapoton
Copy link
Contributor Author

comment:6

Here is a patch, ready for review. I have tried to do my best with respect to coding conventions.

@fchapoton
Copy link
Contributor Author

Author: Frédéric Chapoton

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:7

Attachment: trac_11703-simplicial_K3_surface-fc.patch.gz

This mostly looks good. I'm attaching a referee patch:

  • only import PermutationGroup where it's needed, not at the top-level.
  • add a sentence to the documentation.
  • format the references correctly.

If you're happy with these changes, then the whole ticket can get a positive review.

@jhpalmieri
Copy link
Member

apply on top of other patch

@fchapoton
Copy link
Contributor Author

comment:8

Attachment: trac_11703-referee.patch.gz

This is ok for me. The only point (very minor one) is that the bot does not give a green light, but I guess it does not work very smoothly yet.

@jhpalmieri
Copy link
Member

comment:9

The failures reported by the bot don't seem to have anything to do with this ticket.

@jhpalmieri

This comment has been minimized.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 17, 2011

Merged: sage-4.7.2.alpha3

@nexttime nexttime mannequin removed the s: positive review label Sep 17, 2011
@nexttime nexttime mannequin closed this as completed Sep 17, 2011
@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 23, 2011

comment:12

Jeroen's script should be smart enough to collapse multiple spaces into a single one... 8/

P.S.:

Frédéric, you could add yourself to http://trac.sagemath.org/sage_trac/wiki#AccountNamesMappedtoRealNames.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 23, 2011

Changed author from Frédéric Chapoton to Frédéric Chapoton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants