New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
another example of simplicial complex : the K3 surface #11703
Comments
comment:1
Adding the K3 surface would be great. Can you describe what's involved for the two approaches (storing the data or using the group action)? Then I could make a better suggestion about which to use here. |
comment:2
That would be nice! If there is some reasonably easy way to construct the complex from a group action then it should be done that way so that others can learn from the source code. But just listing raw data would be fine with me, too. |
comment:3
Here is the code with the group (of size 240) and the orbit closure. The other option is just a long list.
|
comment:4
The group action approach looks good to me. Can you post a patch? |
comment:5
Can I "like" this? Also, don't forget the sage developer guide for some nitpicky things about the docstring - this will save the reviewer (presumably jhpalmieri himself) some effort. |
comment:6
Here is a patch, ready for review. I have tried to do my best with respect to coding conventions. |
Author: Frédéric Chapoton |
Reviewer: John Palmieri |
comment:7
Attachment: trac_11703-simplicial_K3_surface-fc.patch.gz This mostly looks good. I'm attaching a referee patch:
If you're happy with these changes, then the whole ticket can get a positive review. |
apply on top of other patch |
comment:8
Attachment: trac_11703-referee.patch.gz This is ok for me. The only point (very minor one) is that the bot does not give a green light, but I guess it does not work very smoothly yet. |
comment:9
The failures reported by the bot don't seem to have anything to do with this ticket. |
This comment has been minimized.
This comment has been minimized.
Merged: sage-4.7.2.alpha3 |
comment:12
Jeroen's script should be smart enough to collapse multiple spaces into a single one... 8/ P.S.: Frédéric, you could add yourself to http://trac.sagemath.org/sage_trac/wiki#AccountNamesMappedtoRealNames. |
Changed author from Frédéric Chapoton to Frédéric Chapoton |
I propose to add to the list of simplicial complexes the minimal triangulation of the K3 surface, which has 16 vertices and 288 facets.
This is can either be defined by storing the data or by recovering it using a group action. What should I prefer ?
Reference : Combinatorial properties of the K3 surface:
Simplicial blowups and slicings by Jonathan Spreer & Wolfgang Kühnel
Apply
CC: @sagetrac-sage-combinat
Component: algebraic topology
Keywords: simplicial complex
Author: Frédéric Chapoton
Reviewer: John Palmieri
Merged: sage-4.7.2.alpha3
Issue created by migration from https://trac.sagemath.org/ticket/11703
The text was updated successfully, but these errors were encountered: