Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement univariate Laurent polynomial ring & elements #11726

Closed
boothby opened this issue Aug 24, 2011 · 45 comments
Closed

Implement univariate Laurent polynomial ring & elements #11726

boothby opened this issue Aug 24, 2011 · 45 comments

Comments

@boothby
Copy link

boothby commented Aug 24, 2011

At present, the implementation of univariate Laurent polynomials is (self-admittedly) in a sorry state:

    ############################################################
    # This should later get moved to an actual single variate  #
    # implementation with valuation tracking,                  #
    # but I don't want to right now.                           #
    ############################################################
    # We need to come up with a name for the inverse that is easy to search
    # for in a string *and* doesn't overlap with the name that we already have.
    # For now, I'm going to use a name mangling with checking method.

This should be fixed.

Apply: attachment: trac_11726-univariate_Laurent_polynomials-ts.patch​

Depends on #14261
Depends on #15345
Depends on #15450
Depends on #15843

CC: @AndrewAtLarge @rwst

Component: commutative algebra

Keywords: sd32, Laurent polynomials

Author: Tom Boothby

Branch/Commit: e27a420

Reviewer: Travis Scrimshaw, Ralf Stephan, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/11726

@boothby

This comment has been minimized.

@boothby

This comment has been minimized.

@boothby boothby changed the title Failure to coerce 1/q into its own LaurentPolynomialRing Implement univariate Laurent polynomial ring & elements Aug 24, 2011
@boothby
Copy link
Author

boothby commented Aug 25, 2011

Changed keywords from none to days32

@boothby boothby assigned boothby and unassigned malb Aug 25, 2011
@boothby
Copy link
Author

boothby commented Aug 25, 2011

Changed keywords from days32 to sd32

@boothby
Copy link
Author

boothby commented Aug 25, 2011

comment:5

Attachment: trac_11726.patch.gz

@boothby
Copy link
Author

boothby commented Aug 25, 2011

Author: Tom Boothby

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Mar 11, 2012

comment:7

This doesn't pass doctests on any recent version of Sage (see patchbot logs)

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Mar 11, 2012

Reviewer: PatchBot

@loefflerd loefflerd mannequin added s: needs work and removed s: needs review labels Mar 11, 2012
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@tscrim
Copy link
Collaborator

tscrim commented Sep 19, 2013

@tscrim
Copy link
Collaborator

tscrim commented Sep 19, 2013

Dependencies: #14261

@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Sep 19, 2013

comment:10

Here's a new version of the patch which applies on sage-5.12.beta5 and depends on #14261 (which is currently being reviewed). This also fixes many things that annoy me with when working with Laurent polynomials, it particular division and simplification in the fraction field.

For patchbot:

Apply: trac_11726-univariate_Laurent_polynomials-ts.patch​

@tscrim
Copy link
Collaborator

tscrim commented Sep 19, 2013

Changed reviewer from PatchBot to Travis Scrimshaw

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

f2e6a35trac #11726 fix one doctest in the en tutorial for kazhdan lusztig polys

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2014

Changed commit from a4e0190 to f2e6a35

@fchapoton
Copy link
Contributor

comment:24

I have corrected the doctest.

@vbraun
Copy link
Member

vbraun commented Apr 4, 2014

comment:25

I think there was more than one, please test.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

1bac8e5trac #11726 correct the other doctest in tutorial

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2014

Changed commit from f2e6a35 to 1bac8e5

@rwst
Copy link

rwst commented Apr 5, 2014

comment:27

Confirm all tutorial tests pass. Oh well, good catch...

@vbraun
Copy link
Member

vbraun commented Apr 6, 2014

comment:28
sage -t --long src/sage/algebras/hall_algebra.py  # 13 doctests failed
sage -t --long src/sage/groups/braid.py  # 8 doctests failed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 8, 2014

Changed commit from 1bac8e5 to eb09160

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 8, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

e07c76eMerge branch 'public/ticket/11726' of trac.sagemath.org:sage into 11726
eb09160trac #11726 implement floordiv for laurent polys in one variable

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 8, 2014

Changed commit from eb09160 to e27a420

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 8, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

e27a420trac #11726 one failing doctest corrected

@fchapoton
Copy link
Contributor

comment:31

I have implemented a __floordiv__ method for Laurent polynomials in one variable, and corrected the doctests. Needs review.

@tscrim
Copy link
Collaborator

tscrim commented Apr 8, 2014

Changed reviewer from Travis Scrimshaw, Ralf Stephan to Travis Scrimshaw, Ralf Stephan, Frédéric Chapoton

@tscrim
Copy link
Collaborator

tscrim commented Apr 8, 2014

comment:32

You seem to have this uncanny ability to do things the night (well for me at least) before I'm going to do them.

@vbraun
Copy link
Member

vbraun commented Apr 9, 2014

Changed branch from public/ticket/11726 to e27a420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants