New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Weierstrass cubic curve class #11823
Comments
Replaces previous |
comment:3
Attachment: trac_11823_singular_elliptic_curves.patch.gz |
replaces previous patch |
Attachment: trac_11823_singular_elliptic_curves.2.patch.gz replace previous (now a class, not a flag) |
Attachment: trac_11823_singular_weierstrass_curves_class.patch.gz Attachment: trac_11823.patch.gz Replaces previous patch |
comment:4
Instead of setting a flag, we have a new class WeierstrassCubic which handles both EllipticCurves and SingularWeierstrassCurves. |
Attachment: Trac_11823.patch.gz replace previous |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Attachment: Trac_11823.2.patch.gz replaces previous |
Attachment: Trac_11823.3.patch.gz Replaces previous |
comment:7
Do you have any plans for this ticket? Is it finished, needs work, abandoned? Having a Also, right now its one huge patch bomb. It would be nice if it could be split into manageable pieces, for example start with |
comment:8
Replying to @vbraun:
Who is "you"?
That's a necessary condition, certainly.
I myself don't need this. I'm also worried that since elliptic curves would be a special case, this would add a new layer of code for all elliptic curves, slowing them down, which would be a Bad Thing. Anyway, it's up to the people who worked on this in the frst place to make their case! |
Add cubic Weierstrass curve class, which can initialize either an elliptic curve or a singular cubic. Implement basic functionality for singular cubic curves, such as: change of Weierstrass form, addition of points, etc.
CC: @adeines @sagetrac-ekin @katestange @sagetrac-jmypark
Component: elliptic curves
Keywords: singular, weierstrass form
Issue created by migration from https://trac.sagemath.org/ticket/11823
The text was updated successfully, but these errors were encountered: