Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subfields should store embedding #11876

Closed
jdemeyer opened this issue Sep 30, 2011 · 4 comments
Closed

Subfields should store embedding #11876

jdemeyer opened this issue Sep 30, 2011 · 4 comments
Assignees
@loefflerd
Labels
c: number fields p: major / 3 t: bug
Milestone
sage-4.7.2

Comments

@jdemeyer
Copy link

If K is a number field with a given embedding, then K.subfield(gen) should inherit that embedding but it does not::

sage: K.<a> = NumberField(x^2-5, embedding=2)
sage: L, phi = K.subfield(-a)
sage: K.specified_complex_embedding()
Generic morphism:
  From: Number Field in a with defining polynomial x^2 - 5
  To:   Real Lazy Field
  Defn: a -> 2.236067977499790?
sage: L.specified_complex_embedding()

Also, if K has no given embedding, then L could at least store an embedding in K.

CC: @mstreng

Component: number fields

Author: Jeroen Demeyer

Reviewer: Marco Streng

Merged: sage-4.7.2.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/11876
@jdemeyer jdemeyer added this to the sage-4.7.2 milestone Sep 30, 2011
@jdemeyer
Copy link
Author

comment:1

Attachment: 11876.patch.gz

@mstreng
Copy link

mstreng commented Oct 3, 2011

Author: Jeroen Demeyer

@mstreng
Copy link

mstreng commented Oct 3, 2011

Reviewer: Marco Streng

@jdemeyer
Copy link
Author

jdemeyer commented Oct 5, 2011

Merged: sage-4.7.2.alpha4

@jdemeyer jdemeyer closed this as completed Oct 5, 2011
@jdemeyer jdemeyer mentioned this issue Nov 3, 2011
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loefflerd loefflerd

Labels
c: number fields p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.7.2
Development

No branches or pull requests
2 participants
@jdemeyer @mstreng