-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend singular_function to non-commutative polynomial rings by refactoring of plural #11892
Comments
comment:1
I forgot to copy-and-paste two lines from the example... |
This comment has been minimized.
This comment has been minimized.
comment:2
It seems that the approach "make However, that change is so small that I tend to include it where I really need it: In #11878. So, this should be closed. |
comment:3
There is a function called |
comment:4
Replying to @sagetrac-PolyBoRi:
Looking at the code, I don't understand why it doesn't work. However, I have to think how to organise work. Things to do involve
These three "to-do"s are closely linked. Do I understand correctly that generally it is better to have several smaller tickets, rather than one big ticket? |
comment:5
I suggest to proceed as follows:
|
comment:7
Sorry, I do not have the time to check anything in detail now. You can use a common base class, if you want. Cheers, |
#4539 provides g-algebras (non-commutative polynomial rings). However,
sage.libs.singular.function.singular_function
doesn't accept them as input.Here is an example that works with usual polynomial rings
The same example fails with a non-commutative polynomial ring:
Apart from the misleading warning about the ideal otained from std not being a standard basis, I think the second example should work.
Two approaches: Add
sage.rings.polynomial.plural.NCPolynomialRing_plural
as a special case tosage.libs.singular.function
, or make the non-commutative rings inherit from the commutative (or probably better the other way around), such that isinstance is happy.Depends on #4539
CC: @saliola @mwhansen @alexanderdreyer @sagetrac-OleksandrMotsak @sagetrac-PolyBoRi @malb @burcin
Component: algebra
Issue created by migration from https://trac.sagemath.org/ticket/11892
The text was updated successfully, but these errors were encountered: