New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ideals in p-adic rings #12053
Comments
comment:2
Attachment: 12053.patch.gz Reviewing this I wondered why this is in the |
comment:3
What is This is a little alarming:
But I see fractional ideals are not implemented. Perhaps there should be a I agree with saraedum's comment above, but for the moment it wouldn't hurt for it to live in padics/, especially as all that code is under heavy active development at the moment. It wouldn't hurt to add some doctests to cover some unramified and ramified extensions of Zp (I tried a few myself and everything seems to work). Apart from these issues the patch looks good to me. |
comment:4
I agree that |
This comment has been minimized.
This comment has been minimized.
Branch: u/saraedum/develop |
Changed branch from u/saraedum/develop to none |
comment:13
Not sure whether you still think that this code is useful…I turned it into a branch so it is easier to see what's going on. |
Branch: u/saraedum/12053 |
Adds a new class for ideals in discrete valuation rings that improves speed and comparison.
Prerequisite for #12077, #8240.
Component: padics
Author: David Roe
Branch: u/saraedum/12053
Issue created by migration from https://trac.sagemath.org/ticket/12053
The text was updated successfully, but these errors were encountered: