Update residue fields to use dynamic classes

[roed314]

Changes sage.rings.residue_fields to use sage.structure.dynamic_class to make it easier to implement p-adic residue fields.

Depends on #12062

Component: number fields

Keywords: residue fields, dynamic classes

Author: David Roe

Branch/Commit: u/saraedum/old_12064 @ 3545bf4

Reviewer: Simon Spicer

Issue created by migration from https://trac.sagemath.org/ticket/12064

[haikona]

comment:2

Is there another dependency? Patch fails to apply cleanly on a fresh copy of 4.8 on top of 12062:

mlungu@sage:~/sage-4.8/devel/sage$ hg qpush
applying 12062.patch
now at: 12062.patch
mlungu@sage:~/sage-4.8/devel/sage$ hg qpush
applying 12064.patch
patching file sage/rings/residue_field.pyx
Hunk #9 succeeded at 553 with fuzz 2 (offset -28 lines).
Hunk #12 FAILED at 743
1 out of 14 hunks FAILED -- saving rejects to file sage/rings/residue_field.pyx.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 12064.patch

[haikona]

Reviewer: spice

[roed314]

comment:4

Updated against 5.0.beta1

[haikona]

comment:5

Looks like there's new trouble when trying to apply 12064 on top of 12062. 12062 has already been applied and Sage built in the output below:

sage@sagebox:~/sage/devel/sage$ hg qpush
applying 12064.patch
patching file sage/rings/finite_rings/finite_field_base.pyx
Hunk #1 succeeded at 90 with fuzz 2 (offset -2 lines).
patching file sage/rings/residue_field.pyx
Hunk #3 succeeded at 139 with fuzz 2 (offset 0 lines).
Hunk #8 succeeded at 435 with fuzz 2 (offset 0 lines).
now at: 12064.patch
sage@sagebox:~/sage/devel/sage$ sage -b

----------------------------------------------------------
sage: Building and installing modified Sage library files.


Installing c_lib
scons: `install' is up to date.
Updating Cython code....
Building modified file sage/rings/residue_field.pyx.
Building modified file sage/rings/finite_rings/finite_field_base.pyx.
Executing 2 commands (using 1 thread)
python `which cython`  --old-style-globals --disable-function-redefinition --embed-positions --directive cdivision=True,autotestdict=False,fast_getattr=True -I/Users/sage/sage-4.8/devel/sage-dev1 -o sage/rings/residue_field.c sage/rings/residue_field.pyx

Error compiling Cython file:
------------------------------------------------------------
...
            K = pring.fraction_field()
            intp = pring.base_ring().order()
            f = p.gen()
            deg = f.degree()
            q = intp**deg
            if k == 1 and intp.is_prime() and (impl is None or impl == 'modn'):
                ^
------------------------------------------------------------

sage/rings/residue_field.pyx:313:17: local variable 'k' referenced before assignment
python `which cython`  --old-style-globals --disable-function-redefinition --embed-positions --directive cdivision=True,autotestdict=False,fast_getattr=True -I/Users/sage/sage-4.8/devel/sage-dev1 -o sage/rings/finite_rings/finite_field_base.c sage/rings/finite_rings/finite_field_base.pyx
Error running command, failed with status 256.
sage: There was an error installing modified sage library code.

[kcrisman]

Changed reviewer from spice to Simon Spicer

[roed314]

comment:7

Fixed. Sorry for the long delay.

[roed314]

Attachment: 12064.patch.gz

[jdemeyer]

comment:8

Attachment: trac_12064_review.patch.gz

[saraedum]

Branch: u/saraedum/old_12064

[sagetrac-git]

Commit: 6ec180c

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6ec180c

Merge branch 'develop' into t/12064/old_12064

[sagetrac-git]

Changed commit from 6ec180c to 7bb1bf3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7bb1bf3

Fix build errors

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5520362

Normalize interface for finite field construction

[sagetrac-git]

Changed commit from 7bb1bf3 to 5520362

[sagetrac-git]

Changed commit from 5520362 to ba525c7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ba525c7

Removed flaky type() tests

[saraedum]

comment:18

The residue_field.pyx file is now down to three doctests.

---

New commits:

ba525c7

Removed flaky type() tests

---

New commits:

ba525c7

Removed flaky type() tests

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3545bf4

Merge remote-tracking branch 'trac/develop' into HEAD

[sagetrac-git]

Changed commit from ba525c7 to 3545bf4