sage-location doesn't deal with packages after initialize_pkgconfig_files has run

[sagetrac-mariah]

sage-4.7.2 with optional package libogg-1.1.4.spkg installed.
Now when I move the sage tree I get:

eno% ./sage
----------------------------------------------------------------------
| Sage Version 4.7.2, Release Date: 2011-10-29                       |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
The Sage installation tree may have moved
(from /home/mariah/sage/sage-4.7.2-x86_64-Linux-core2-fc to /home/mariah/sage/sage-4.7.2-x86_64-Linux-core2-fc-libogg-test).
Changing various hardcoded paths...
(Please wait at most a few minutes.)
DO NOT INTERRUPT THIS.
Error: sage_location: update_pkgconfig_files():
  File "ogg.pc" doesn't contain a definition of SAGE_ROOT.
  Skipping it...
Done resetting paths.
sage:

Apply:

Both trac_12076.patch and
trac_12076-2.patch.

Component: scripts

Keywords: sd40.5

Author: Mike Hansen

Reviewer: Dan Drake, Karl-Dieter Crisman

Merged: sage-5.1.beta4

Issue created by migration from https://trac.sagemath.org/ticket/12076

[mwhansen]

comment:1

Attachment: trac_12076.patch.gz

[mwhansen]

Author: Mike Hansen

[mwhansen]

Changed keywords from none to sd40.5

[dandrake]

comment:2

The patch here appears to fix the problem, but I notice that the ogg.pc file looks a little different from all the others:

drake@sagenb:~/s/y5.1.b0/local/lib/pkgconfig$ grep ^prefix= *
bdw-gc.pc:prefix=${SAGE_ROOT}/local
freetype2.pc:prefix=${SAGE_ROOT}/local
gnutls-extra.pc:prefix=${SAGE_ROOT}/local
gnutls.pc:prefix=${SAGE_ROOT}/local
gsl.pc:prefix=${SAGE_ROOT}/local
libpng12.pc:prefix=${SAGE_ROOT}/local
libpng.pc:prefix=${SAGE_ROOT}/local
m4ri.pc:prefix=${SAGE_ROOT}/local
ogg.pc:prefix=/home/drake/s/5.1b0/local
opencdk.pc:prefix=${SAGE_ROOT}/local
pynac.pc:prefix=${SAGE_ROOT}/local
python-2.7.pc:prefix=${SAGE_ROOT}/local
python.pc:prefix=${SAGE_ROOT}/local
sqlite3.pc:prefix=${SAGE_ROOT}/local
zlib.pc:prefix=${SAGE_ROOT}/local

Observe that only ogg.pc has the original SAGE_ROOT in its prefix; all other files have prefix in terms of SAGE_ROOT. Is that what we want? Is that okay?

[mwhansen]

comment:3

After installing the patch, did you move the Sage directory and start it?

[dandrake]

comment:4

Replying to @mwhansen:

After installing the patch, did you move the Sage directory and start it?

I did. And the relocation appears to work properly. I'm mostly just curious about the difference in the .pc file.

[kcrisman]

comment:5

I can confirm this problem, and that this patch fixes it, and the patch seems right, just abstracting out something.

But Dan and I agree that

        config = config.replace(SAGE_ROOT_absolute, "${SAGE_ROOT}")

seems to not be happening here for some reason. But maybe we are parsing it wrong.

[mwhansen]

comment:6

The new patch, which applies on top of the previous one, should (really!) fix this issue.

[dandrake]

Reviewer: Dan Drake

[dandrake]

comment:7

Attachment: trac_12076-2.patch.gz

Whew! These two patches now fix the problem. To be sure, I'd like one more person to look at this, and then we'll do a positive review.

[dandrake]

comment:9

Karl-Dieter Crisman tried this and it works as expected. Positive review.

[dandrake]

Changed reviewer from Dan Drake to Dan Drake, Karl-Dieter Crisman

[jdemeyer]

Merged: sage-5.1.beta4