Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comparison R == Z #12127

Closed
sagetrac-fschulze mannequin opened this issue Dec 8, 2011 · 12 comments
Closed

fix comparison R == Z #12127

sagetrac-fschulze mannequin opened this issue Dec 8, 2011 · 12 comments

Comments

@sagetrac-fschulze
Copy link
Mannequin

sagetrac-fschulze mannequin commented Dec 8, 2011

Two methods in schemes/generic/homset.py contain a comparison 'R == Z' instead of 'R == ZZ'.

Fixed by #11526.

CC: @saraedum @vbraun

Component: algebraic geometry

Keywords: sd40.5

Reviewer: Andrey Novoseltsev, Frithjof Schulze

Issue created by migration from https://trac.sagemath.org/ticket/12127

@sagetrac-fschulze sagetrac-fschulze mannequin added this to the sage-4.8 milestone Dec 8, 2011
@saraedum
Copy link
Member

saraedum commented Dec 9, 2011

comment:1

Apparently this was introduced in [changeset:15345:08d4a1aad8b5].

About the doctests, could you provide some example which triggers the bug? We could probably use that for the doctest.

@novoselt
Copy link
Member

novoselt commented Dec 9, 2011

comment:2

See also #11526.

@sagetrac-fschulze
Copy link
Mannequin Author

sagetrac-fschulze mannequin commented Dec 9, 2011

comment:3

I changed the #11526 patch to also fix the typo in the projective case.

@sagetrac-fschulze sagetrac-fschulze mannequin removed this from the sage-4.8 milestone Dec 9, 2011
@novoselt
Copy link
Member

Changed keywords from none to sd40.5

@novoselt
Copy link
Member

Reviewer: Andrey Novoseltsev

@saraedum
Copy link
Member

Author: Frithjof Schulze

@saraedum
Copy link
Member

comment:7

Replying to @saraedum:

Oops. Should have read what was written in the ticket. Setting an author here doesn't make much sense.

@jdemeyer
Copy link

comment:8

This needs to be rebased to sage-5.1.beta0:

patching file sage/schemes/generic/homset.py
Hunk #1 FAILED at 159
Hunk #2 FAILED at 218
2 out of 2 hunks FAILED -- saving rejects to file sage/schemes/generic/homset.py.rej

@novoselt
Copy link
Member

comment:9

This ticket just has to be closed without merging anything!

@jdemeyer
Copy link

jdemeyer commented Jun 2, 2012

Changed reviewer from Andrey Novoseltsev to Andrey Novoseltsev, Frithjof Schulze

@jdemeyer
Copy link

jdemeyer commented Jun 2, 2012

Changed author from Frithjof Schulze to none

@jdemeyer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants