New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parallel building zlib #12138
Comments
Upstream: Not yet reported upstream; Will do shortly. |
This comment has been minimized.
This comment has been minimized.
Author: Jeroen Demeyer |
comment:3
John, could you please test both the old and new zlib spkgs using
(or some other value of j) On Linux, I do not manage to reproduce the issue. |
comment:4
Managed to reproduce anyway with the old zlib on sage.math, not with the new one here. So looks good, but needs formal review. |
Changed upstream from Not yet reported upstream; Will do shortly. to Reported upstream. Little or no feedback. |
Attachment: zlib-1.2.5-p0.diff.gz Diff for the zlib spkg, for review only |
This comment has been minimized.
This comment has been minimized.
comment:6
Looks good to me and builds consistently on sage.math and on OS X, under circumstances where the old spkg failed. (For example, on OS X, I got the old spkg to fail on 7 out of 10 builds, while this one built 20 times in row with no failures, and similarly on sage.math, using |
Reviewer: John Palmieri |
Merged: sage-4.8.alpha4 |
See http://sage.math.washington.edu/home/palmieri/misc/zlib-1.2.5.log
New spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/zlib-1.2.5.p0.spkg
Reported upstream by personal email to the address given on http://zlib.net/
Upstream: Reported upstream. Little or no feedback.
CC: @jhpalmieri
Component: packages: standard
Author: Jeroen Demeyer
Reviewer: John Palmieri
Merged: sage-4.8.alpha4
Issue created by migration from https://trac.sagemath.org/ticket/12138
The text was updated successfully, but these errors were encountered: