Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel building zlib #12138

Closed
jdemeyer opened this issue Dec 9, 2011 · 11 comments
Closed

Fix parallel building zlib #12138

jdemeyer opened this issue Dec 9, 2011 · 11 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Dec 9, 2011

See http://sage.math.washington.edu/home/palmieri/misc/zlib-1.2.5.log

New spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/zlib-1.2.5.p0.spkg

Reported upstream by personal email to the address given on http://zlib.net/

Upstream: Reported upstream. Little or no feedback.

CC: @jhpalmieri

Component: packages: standard

Author: Jeroen Demeyer

Reviewer: John Palmieri

Merged: sage-4.8.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/12138

@jdemeyer jdemeyer added this to the sage-4.8 milestone Dec 9, 2011
@jdemeyer
Copy link
Author

jdemeyer commented Dec 9, 2011

Upstream: Not yet reported upstream; Will do shortly.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

jdemeyer commented Dec 9, 2011

Author: Jeroen Demeyer

@jdemeyer
Copy link
Author

jdemeyer commented Dec 9, 2011

comment:3

John, could you please test both the old and new zlib spkgs using

MAKEFLAGS="j8" ./sage -f zlib...

(or some other value of j)

On Linux, I do not manage to reproduce the issue.

@jdemeyer
Copy link
Author

jdemeyer commented Dec 9, 2011

comment:4

Managed to reproduce anyway with the old zlib on sage.math, not with the new one here. So looks good, but needs formal review.

@jdemeyer
Copy link
Author

jdemeyer commented Dec 9, 2011

Changed upstream from Not yet reported upstream; Will do shortly. to Reported upstream. Little or no feedback.

@jdemeyer
Copy link
Author

jdemeyer commented Dec 9, 2011

Attachment: zlib-1.2.5-p0.diff.gz

Diff for the zlib spkg, for review only

@jdemeyer

This comment has been minimized.

@jhpalmieri
Copy link
Member

comment:6

Looks good to me and builds consistently on sage.math and on OS X, under circumstances where the old spkg failed. (For example, on OS X, I got the old spkg to fail on 7 out of 10 builds, while this one built 20 times in row with no failures, and similarly on sage.math, using MAKEFLAGS='j -l2' ./sage -f ....)

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jdemeyer
Copy link
Author

Merged: sage-4.8.alpha4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants