-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in global_integral_model for elliptic curves over number fields #12151
Comments
comment:1
This can be fixed by changing
on line 564 of ell_number_field.py to
or alternatively (I think)
I checked that the first alternative works. NB I also think that the line
should be
since we will divide by a power of pi and want to make sure that the model stays integral at other primes. This does not matter in the example given where the class number is 1 so each pi will be an actual generator of the prime ideal. |
Attachment: 12151.patch.gz |
Author: Johan Bosman |
comment:2
Changing |
comment:3
Replying to @sagetrac-johanbosman:
I have CC'd Chris Wuthrich who made the patch at #7935 (where I made a comment on exactly that line). |
Reviewer: David Loeffler |
Changed author from Johan Bosman to Johan Bosman, John Cremona |
comment:4
This looks fine to me. |
Merged: sage-5.0.beta9 |
Component: elliptic curves
Author: Johan Bosman, John Cremona
Reviewer: David Loeffler
Merged: sage-5.0.beta9
Issue created by migration from https://trac.sagemath.org/ticket/12151
The text was updated successfully, but these errors were encountered: