Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken doctests in magma.py for integers in QQ and conversion of number field elements #12154

Closed
mstreng opened this issue Dec 14, 2011 · 12 comments

Comments

@mstreng
Copy link

mstreng commented Dec 14, 2011

A later patch at #12006 does everything this patch does, and more. Now that ticket is closed, so this one can be closed too.

In 4.7.2, I get

        sage -t -only-optional=magma devel/sage/sage/schemes/elliptic_curves/ell_generic.py # 1 doctests failed
        sage -t -only-optional=magma devel/sage/sage/schemes/plane_conics/con_field.py # 1 doctests failed
        sage -t -only-optional=magma devel/sage/sage/interfaces/magma.py # 11 doctests failed
        sage -t -only-optional=magma devel/sage/sage/rings/polynomial/multi_polynomial.pyx # 1 doctests failed

Most of these are because 1 in QQ is now converted to Magma as "1/1" instead of "1". The other one is a simple Sage error introduced in #11580 (x is redefined as a variable in a multivariate polynomial ring and then used again as if this never happened).

Component: interfaces

Keywords: magma interface, rational, relative number field

Reviewer: Marco Streng

Issue created by migration from https://trac.sagemath.org/ticket/12154

@mstreng
Copy link
Author

mstreng commented Dec 14, 2011

@mstreng
Copy link
Author

mstreng commented Dec 14, 2011

comment:2

I'm writing a patch.

Apparently some breaking of magma doctests went unnoticed in both #6329 and #11580.

@mstreng
Copy link
Author

mstreng commented Dec 14, 2011

comment:3

Another cause of failures is conversion via _repr_, which is the default, but is quite unstable, as variable names are sometimes already initialized in Magma, so I will remove that from relative number field elements.

@mstreng
Copy link
Author

mstreng commented Dec 14, 2011

Attachment: 12154-magma-doctest.patch.gz

@mstreng
Copy link
Author

mstreng commented Dec 14, 2011

Changed work issues from change doctests only to none

@mstreng
Copy link
Author

mstreng commented Dec 14, 2011

Changed keywords from none to magma interface, rational, relative number field

@mstreng
Copy link
Author

mstreng commented Dec 14, 2011

Author: Marco Streng

@mstreng

This comment has been minimized.

@mstreng
Copy link
Author

mstreng commented Feb 9, 2012

comment:6

The new _magma_init_ in number_field_element.pyx gives me "1 out of 1 hunks FAILED"

@mstreng
Copy link
Author

mstreng commented Feb 14, 2012

Reviewer: Marco Streng

@mstreng
Copy link
Author

mstreng commented Feb 14, 2012

Changed author from Marco Streng to none

@mstreng

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants