Placing triangulation and normal cones

[vbraun]

This ticket implements some more functionality for triangulations:

• the placing triangulation is a triangulation that can be computed faster than the currently used lexicographic triangulation.
• the normal cone of a triangulation

Apply

• attachment: trac_12159_separate_triangulation_file.patch
• attachment: trac_12159_placing_triangulation.patch
• attachment: trac_12159_normal_cone.patch

CC: @novoselt

Component: geometry

Author: Volker Braun

Reviewer: Marshall Hampton

Merged: sage-5.0.beta9

Issue created by migration from https://trac.sagemath.org/ticket/12159

[vbraun]

Initial patch

[vbraun]

Attachment: trac_12159_separate_triangulation_file.patch.gz

Initial patch

[vbraun]

comment:1

Attachment: trac_12159_placing_triangulation.patch.gz

[sagetrac-mhampton]

comment:3

A bunch of doctests fail after installing the TOPCOM package, presumably just because of different choices of triangulations. I can't think of a nice way to deal with that offhand, it would be pretty clunky to force every example to use the Sage-native code.

[sagetrac-mhampton]

comment:4

OK, maybe its not so bad. Adding in a few more "set_engine('internal')" and "engine='internal'" lines to element.py in geometry/triangulation is enough to fix all the doctest errors.

[sagetrac-mhampton]

comment:5

I imagine that is trivial for Volker to do himself but in case its helpful here is my version that passes the doctests after TOPCOM is installed:
element.py

[vbraun]

Attachment: trac_12159_normal_cone.2.patch.gz

Updated patch

[vbraun]

Updated patch

[vbraun]

comment:6

Attachment: trac_12159_normal_cone.patch.gz

Updated patch fixes doctests with TOPCOM installed.

[loefflerd]

comment:7

Apply trac_12159_separate_triangulation_file.patch, trac_12159_placing_triangulation.patch, trac_12159_normal_cone.patch

(for the patchbot)

[sagetrac-mhampton]

comment:8

I have not checked the mathematics of this patch in depth, but it passes all doctests and coverage checks, the documentation looks good, and what I have checked seems correct. The problems with doctests after TOPCOM is installed have been fixed. So I am happy to give it a positive review.

[sagetrac-mhampton]

Reviewer: Marshall Hampton

[jdemeyer]

Merged: sage-5.0.beta9