New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libfplll error codes - leftover from #1188 #1217
Comments
Changed keywords from none to wjp |
comment:1
Checking for "< 0" seems to be fine as far as I can see (we do that). So I vote for |
Changed keywords from wjp to none |
comment:4
I think that we should check for != 0 in all fpLLL calls that are guaranteed to return an LLL-reduced basis, including 'wrapper'. Rationale: Damien Stehlé writes:
This means that a positive value indicates a non-reduced basis, which is an error condition for the proved fpLLL functions. (The actual returned value kappa seems to indicate the row in which the size-reduction failed.) malb: on IRC, you mentioned a testcase that triggered a positive return value in the main wrapper. Which one? The doctest in |
comment:5
I suggest to check for
as this seems to be correct and to worry about resulting errors afterwards. |
comment:7
That makes sense. The attached patch implements it. |
Attachment: 8015.patch.gz |
comment:9
The patch looks good and applies cleanly, but:
This is on a 64-bit Linux. I assume this can be reproduced on PS: Trying something bold and reassigning this ticket to wjp, feel free to bounce it. |
comment:10
|
comment:11
The patch is fine, it just exposes a bug on my machine. I say apply. |
comment:12
Merged in Sage 2.10.1.alpha1 |
On IRC:
For a patch see fplll2.patch from #1188.
Cheers,
Michael
Component: packages: standard
Issue created by migration from https://trac.sagemath.org/ticket/1217
The text was updated successfully, but these errors were encountered: